[tvOS] App Settings & Splashscreen #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPKribs
reviewed
Feb 6, 2025
Swiftfin tvOS/Views/AppSettingsView/Components/SignOutIntervalSection.swift
Outdated
Show resolved
Hide resolved
added 2 commits
February 6, 2025 17:23
JPKribs
reviewed
Feb 7, 2025
Swiftfin tvOS/Views/AppSettingsView/Components/SignOutIntervalSection.swift
Show resolved
Hide resolved
LePips
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
I removed the Accessibility section since we won't be supporting switching app icons or light mode. Alternate app icon support is different on tvOS, at least when I looked at it years ago.
I also implemented the Menu for the server selection for the splash screen to use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this is using the same AppSettingsView brought over from iOS. I was going to make the view shared but it doesn't look like a pattern used in project so far so I have kept them separate. The big difference here is the sign-out on background setting is still disabled due to the lack of a date picker on tvOS. I did find a potential library but wanted input first.
There also was some earlier work in this view that was commented out which included resetting user settings and removing all servers, does that need to stay for future completion?
Toggling Splashscreen:
splashscreen.mp4
Signout on Close
signout.mp4