Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tvOS] Change password to be a SecureField and autosubmit on password comple… #1090

Merged
merged 4 commits into from
Oct 6, 2024

Conversation

petermcneil
Copy link
Contributor

…tion

Copy link
Member

@LePips LePips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, just some changes.

@petermcneil petermcneil changed the title Change password to be a SecureField and autosubmit on password comple… [tvOS] Change password to be a SecureField and autosubmit on password comple… Oct 3, 2024
@petermcneil
Copy link
Contributor Author

I've added in a fix for the SelectUserViewModel. When I was on the user selection page, I would click on the button for my user and it would do nothing. After following the flow with logging I found that the message just stopped when sending back via that events publisher.

Removing .receive(on: RunLoop.main) made it work. I'm not really sure why, something to do with the scheduling. I'm obviously new to Swift, let me know if that was the wrong thing to do. Once I removed it I was able to login and do the rest of the actions in the tvOS app.

I got the "solution" from here - https://forums.swift.org/t/combine-receive-on-runloop-main-loses-sent-value-how-can-i-make-it-work/28631/24

@LePips LePips merged commit 5d59d57 into jellyfin:main Oct 6, 2024
4 checks passed
@petermcneil petermcneil deleted the secure-field branch October 6, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants