Bug-fix/fixes memory leaks in priority queue #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Agreed that this is always a problem since a pointer is stored in the array. |
|
it's released, thanks for the contribution! |
|
Happy to contribute and thanks for the quick response. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Pop() in the implementation of the priorityQueue is re-slicing the items array. This lead to the slice being shrunk down but the reference to the item is still maintained by the underlying array. Because of this, the golang GC assumes that the item was still accessible and thus didn’t deallocate it. This is resulting in memory leaks when the application is run for very long sessions. More information can be found on this SO entry.