Don't load Gemoji into memory immediately #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkr
approved these changes
Mar 4, 2020
There was a problem hiding this comment.
Wow, that's a lot of memory!
Total allocated: 7.07 MB (76405 objects)
Total retained: 1.15 MB (21140 objects)
allocated memory by file
-----------------------------------
4.63 MB /Users/parkr/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/gemoji-3.0.1/lib/emoji.rb
1.29 MB /Users/parkr/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/json-2.2.0/lib/json/common.rb
|
Looks like the gemoji library could use some |
mattr-
approved these changes
Mar 4, 2020
|
@jekyllbot: merge +minor |
@parkr Took care of that months ago 😉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jekyll loads all plugins at a very early stage in the build process.
However,
lib/emoji.rbdoesn't directly reference any object initialized by thegemojigem. The heavy-lifting is done byhtml-pipelinegem (which ultimately loads thegemojilibrary anyway, but it does so much later, after Jekyll's:post_renderhas been triggered).For the curious, you may run the following script (via Bundler) to get an idea: