Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for old Ruby and old Jekyll #55

Merged
merged 1 commit into from
Oct 30, 2017
Merged

Drop support for old Ruby and old Jekyll #55

merged 1 commit into from
Oct 30, 2017

Conversation

jekyllbot
Copy link
Contributor

PR automatically created for @pathawks.

Drop support for old Ruby and old Jekyll

@pathawks pathawks requested a review from mattr- October 24, 2017 01:45
@pathawks pathawks added this to the 2.0.0 milestone Oct 24, 2017
@ashmaroli
Copy link
Member

Jekyll dropped support for Ruby 2.0.x because its dependency Liquid dropped support for Ruby 2.0, Now another dependency (this plugin) is going to force Jekyll to drop support for Ruby 2.1 as well...
In about 5months, Ruby 2.2 will become EOL as well.. perhaps some other dependency may drop support for Ruby 2.2 which would force Jekyll to yield again..

Sad..

@pathawks
Copy link
Member

I guess we don't have to drop support for Ruby 2.1, but it is EOL so it seems like everybody should drop support.

@pathawks
Copy link
Member

@ashmaroli You do raise a good point though. Because this plugin is required by Jekyll, it's requirements should be no more strict than Jekyll's requirements.

@ashmaroli
Copy link
Member

I guess we don't have to drop support for Ruby 2.1

As a matter of fact, you have little choice here now because listen 3.1 has dropped support for Ruby 2.1

@pathawks
Copy link
Member

As a matter of fact, you have little choice here now because listen 3.1 has dropped support for Ruby 2.1

Do we need listen 3.1? We don't require it.

@ashmaroli
Copy link
Member

We don't require it.

Ah right.. my bad.. I assumed #50 would cause one to depend on Listen 3.1..
We're safe then..

@pathawks
Copy link
Member

It allows a later version of Listen, but locking to listen 3.0 still works.

@pluehne pluehne mentioned this pull request Oct 30, 2017
1 task
@DirtyF
Copy link
Member

DirtyF commented Oct 30, 2017

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit da23f75 into master Oct 30, 2017
@jekyllbot jekyllbot deleted the pull/deps branch October 30, 2017 14:29
jekyllbot added a commit that referenced this pull request Oct 30, 2017
@ashmaroli
Copy link
Member

@DirtyF I believe this wasn't ready for a merge..
we can't have jekyll-watch drop support for Ruby 2.1 which Jekyll still supports..

@DirtyF
Copy link
Member

DirtyF commented Oct 30, 2017

listen is right we should also drop support for Ruby 2.1 it's EOL.

@DirtyF
Copy link
Member

DirtyF commented Oct 30, 2017

amended in b1dd7e7 and opened jekyll/jekyll#6503

@jekyll jekyll locked and limited conversation to collaborators Apr 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants