Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a custom timestamp format in yaml frontmatter on posts #98

Merged
merged 5 commits into from
Dec 3, 2019

Conversation

alzeih
Copy link
Contributor

@alzeih alzeih commented Sep 3, 2019

Using --timestamp-format "%Y-%m-%d %H:%M %z" the commands jekyll post and jekyll publish can have a user specified format to give to strftime for the yaml frontmatter on posts.

If not specified, the default format is used.

Signed-off-by: alzeih <alzeih@users.noreply.github.com>
@DirtyF DirtyF requested a review from a team September 3, 2019 11:22
@mattr-
Copy link
Member

mattr- commented Sep 3, 2019

I like this idea. Could you update the PR to remove the conflicts? Once that's done, I'll give it a proper review.

Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, but please provide an example of this option in the documentation. Thanks.

Signed-off-by: alzeih <alzeih@users.noreply.github.com>
@alzeih
Copy link
Contributor Author

alzeih commented Sep 3, 2019

I have documented --timestamp-format in README.md for the post and publish commands using an example format "%Y-%m-%d %H:%M:%S %z" that differs from the default at Jekyll::Compose::DEFAULT_TIMESTAMP_FORMAT.

@DirtyF DirtyF requested review from ashmaroli and mattr- September 7, 2019 08:35
@DirtyF DirtyF added the feature label Sep 7, 2019
@alzeih
Copy link
Contributor Author

alzeih commented Sep 7, 2019

Please hold this PR open until after #103 has been resolved, as jekyll compose will need to support this too if accepted.

@DirtyF
Copy link
Member

DirtyF commented Dec 3, 2019

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit eabf9f6 into jekyll:master Dec 3, 2019
jekyllbot added a commit that referenced this pull request Dec 3, 2019
@jekyll jekyll locked and limited conversation to collaborators Dec 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants