-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.NET Core (>= v1.1) support. #76
Open
huchim
wants to merge
14
commits into
jehugaleahsa:master
Choose a base branch
from
huchim:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assembly info works differente in NetCore, and SecurityElement it isn't ported.
NetCore fails when we use typeof(Resources).Assamblye instead of GetTypeInfo().
All package information is in the csproj. I'm using mustache-sharp-core to compile the project using netcore and don't break original compilation.
• Add suport to netcore • Disable `ShouldReturnNullIfNotDictionaryType` test. Im not sure how to implement it correctly.
• Add solution with the net core project and test project. • Update AssemblyInfo to test with the `mustache-sharp-core.test`project.
• Update nuget CLI, we need -ForeEnglishOutput flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.NET Core 1.1 was released at november 17 and there are 3 releases more after 1.1 (1.1.1, 1.1.2 & 2.0.0).
This code don't break your current compilation because I created 1 solution
mustache-sharp-core.sln
with two projects:mustache-sharp\mustache-sharp.csproj
andmustache-sharp.test\mustache-sharp-core.test.csproj
that include your code.mustache-sharp.csproj
This project include all files of your original project but the information of nuget is in the project itself and don't use the
.nuspec
file.I added directive
NETCOREAPP1_1
:PropertyDictionary.cs
usetype.GetTypeInfo()
when compilation is in .NETCore.UpcastDictionary.cs
usetype.GetTypeInfo()
when compilation is in .NETCore.HtmlFormatCompiler.cs
changes implementation of methodescapeInvalidHtml(object, TagFormattedEventArgs)
becauseSecurityManager
it's not avalaible.Properties\Resources.Designer.cs
The problem with the resource file is that is "auto-generated" and the original version is that use
typeof
and now we need to useGetTypeInfo()
. Visual Studio 2017 generate the file corrrectly but I don't wan't to break the compilation.I created a copy of the file with de name
Resources.Core.resx
and the generated fileResources.Core.Designer.cs
had a class namedResources_Core
.I added this code to the files, and only works with the net core, so won't break current compilation.
Nuget
All nuget package is in the
csproj
file, but thenuspec
was not touched. I created a powershell script (nuget-version.ps1
) that push the package to the nuget. The package is compiled but VisualStudio.com services using my branch (I needed the package "urgently").I updated nuget.exe to version 3.5.
This is my first pull request and I tried to don't break your current compilation using directives and creating
csproj
, my main interest on this project is to generate reports with my code using mustache, and your code works nice.Kind regards
Carlos Huchim
Yucatán, México.