feat: add selectFocusedOnSubmit option #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any use case for this feature? In my opinion, it's better to set a default value. @akuntsch |
For me (and my team) there is, yes. We have a prompt with a big list of dynamic options and quite often you only want to select a single one but not always the same one (so a default value would not make sense). |
|
That make sense. Can you add a test case? |
akuntsch
force-pushed
the
feature/auto-select-focused
branch
from
12103bd to
3d6fad5
Compare
|
Released in 1.0.0-alpha.9. @akuntsch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to automatically select the currently focused option when pressing enter and no other options are already selected (when
multiple=true).