Vim 0.10.0 breaks dim colorscheme

[hexcowboy]

Seems like quite a few things have broken in the upgrade to neovim 0.10.0. Particularly, string colors are no longer red.

[schrobingus]

The affected highlights appear to be Function and String, so rebinding both of those should fix the issue altogether.

:highlight Function ctermfg=6
:highlight String ctermfg=1

I'm also working on a Lua rewrite of Dim to keep up with the more rolling nature of Neovim.

[jeffkreeftmeijer]

I'd accept a patch for this.

[hexcowboy]

@schrobingus please make sure to ping back here if you do update it! much appreciated

[schrobingus]

diff --git a/colors/default-light.vim b/colors/default-light.vim
index d49cff2..aafee36 100644
--- a/colors/default-light.vim
+++ b/colors/default-light.vim
@@ -24,6 +24,8 @@ highlight CursorLine     cterm=underline
 highlight MatchParen     ctermbg=14
 highlight Constant       ctermfg=1
 highlight Special        ctermfg=5
+highlight Function       ctermfg=6
+highlight String         ctermfg=1
 highlight Identifier     cterm=NONE ctermfg=6
 highlight Statement      ctermfg=3
 highlight PreProc        ctermfg=5
diff --git a/colors/grim.vim b/colors/grim.vim
index 0853e91..eac0e88 100644
--- a/colors/grim.vim
+++ b/colors/grim.vim
@@ -5,6 +5,8 @@ let colors_name = "grim"
 if &background == "light"
   highlight Constant       ctermfg=8
   highlight Identifier     ctermfg=0
+  highlight Function       ctermfg=0
+  highlight String         ctermfg=0
   highlight PreProc        ctermfg=0 cterm=bold
   highlight Special        ctermfg=0
   highlight Statement      ctermfg=0 cterm=bold
@@ -14,6 +16,8 @@ if &background == "light"
 else
   highlight Constant       ctermfg=7
   highlight Identifier     ctermfg=15
+  highlight Function       ctermfg=15
+  highlight String         ctermfg=15
   highlight PreProc        ctermfg=15 cterm=bold
   highlight Special        ctermfg=15
   highlight Statement      ctermfg=15 cterm=bold

@jeffkreeftmeijer Here is a patch applying the highlights. I also added this to Grim since it is also affected here, albeit I wasn't sure what highlight to substitute in, so I just did 0 and 15 respectively.

[clach04]

I'd accept a patch for this.

#13

[hexcowboy]

There are still many colors broken since the 0.10.0 upgrade, #13 is still not enough. I ended up switching to another scheme so I won't be adding any more to #13.