feat: add support for 4090 series (US - b&h/newegg/bestbuy) #3085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmos
changed the title
mrmos
changed the title
mrmos
changed the title
|
https://github.com/Mr-Tech-13/4090-tracker This is my fork, updated for 4080 just today. Feel free to add this to your code! |
jef
approved these changes
Nov 28, 2022
jef
reviewed
Nov 28, 2022
| @@ -262,6 +263,7 @@ Used with the `SHOW_ONLY_SERIES` variable. | |||
| | Nvidia RTX 3080 | `3080` | | |||
| | Nvidia RTX 3080 Ti | `3080ti` | | |||
| | Nvidia RTX 3090 | `3090` | | |||
| | Nvidia RTX 3090 | `4090` | | |||
There was a problem hiding this comment.
Suggested change
| | Nvidia RTX 3090 | `4090` | | |
| | Nvidia RTX 4090 | `4090` | |
There was a problem hiding this comment.
Once you update this @mrmos, we can merge this in! Thanks for your contribution :)
There was a problem hiding this comment.
Actually I'm going to go ahead and merge this then update myself.
Thank you!
jef
changed the title
jef
added a commit
that referenced
this pull request
Nov 28, 2022
🤖 I have created a release *beep* *boop* --- ## [3.8.0](v3.7.1...v3.8.0) (2022-11-28) ### Features * add support for 4090 series (US - b&h/newegg/bestbuy) ([#3085](#3085)) ([0c84075](0c84075)) * **unifi:** adds protect products ([#3082](#3082)) ([fa7c423](fa7c423)) ### Documentation * change 3090 to 4090 ([dccaa52](dccaa52)) * update badges ([82cafc4](82cafc4)) ### Continuous Integration * fix cache ([e1b4320](e1b4320)) * replace runs with run ([9ec2018](9ec2018)) * use github actor ([cf83753](cf83753)) * use github token ([27dc9d2](27dc9d2)) * use single quotes ([bfc5bfd](bfc5bfd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Sorry i never got back to you earlier. Here are all the store files I edited to add the 4090s (over a month ago though, so probably not quite up to date). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adds support for all available 4090 models on bh + newegg + bestbuy.
can add more stores as needed, but wanted to get the ball rolling.
new contributor to this project, so let me know if there's anything I missed.
Thanks!