Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bestbuy): shorter pageview urls and missing carturl links #1613

Merged
merged 14 commits into from
Jan 7, 2021
Merged

fix(bestbuy): shorter pageview urls and missing carturl links #1613

merged 14 commits into from
Jan 7, 2021

Conversation

wofnull
Copy link
Contributor

@wofnull wofnull commented Jan 6, 2021

Description

Quickfix for #1610 + additional missing cartUrls in bestbuy.ts

  • Updated all URLs to shorter format ( some were already in correct format , some where in other formats )
  • added several carturls, that were missing in original file

Testing

Verified that bestbuy runs through without issues on test script

wofnull added 12 commits December 29, 2020 17:30
@wofnull
Update mediamarkt.ts
6e558db
@wofnull
Updated saturn.ts together with mediamarkt.ts
b7c184a 
Fixxed bugs found in Mediamarkt / Saturn Webstore, after Change to their shop after 29.12.2020
@wofnull
Bugfix Galaxus, updated to .ZZf1 from old entry
9316271
@wofnull
Merge remote-tracking branch 'origin/Bugfix_galaxus' into main
91e90d3
@wofnull
fix: Galaxus again changed the CSS marker for the product_details cha…
50021d0 
…nged once before
@wofnull
Merge branch 'Bugfix_galaxus_01.01.2020' into main
b55678e 
# Conflicts:
#	src/store/model/galaxus.ts
@wofnull
Merge remote-tracking branch 'upstream/main' into main
ccad26a
@wofnull
Merge remote-tracking branch 'upstream/main' into main
57ca268
@wofnull
Merge branch 'main-upstream' into main
d8e75d5
@wofnull
Merge branch 'main-upstream' into main
11597f5
@wofnull
shortened the pageview links to use the format https://api.bestbuy.co…
3856230 
…m/click/-/[PRODUCTNUMBER]/pdp
@wofnull
Added missing cartURL Links to bestbuy,
86ee2ce
@wofnull wofnull requested a review from jef as a code owner January 6, 2021 12:06
@wofnull wofnull mentioned this pull request Jan 6, 2021
Closed
jef
jef approved these changes Jan 7, 2021
View reviewed changes
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh awesome! This is pretty cool. Thanks for putting this together!

@jef jef merged commit 8faf320 into jef:main Jan 7, 2021
@wofnull wofnull deleted the BestBuy-Cleanup branch January 8, 2021 11:49
erwinc1 pushed a commit to erwinc1/streetmerchant that referenced this pull request Mar 31, 2021
@wofnull @erwinc1
fix(bestbuy): shorter pageview urls and missing carturl links (jef#1613)
c14da0e 
Fixes jef#1610
@github-actions github-actions bot mentioned this pull request Oct 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jef jef jef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wofnull @jef