feat(lookup): Add protection against infinite recursion for Cloudflare… #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… never moves past its DDoS protection page
jef
approved these changes
Dec 24, 2020
|
This seems to be happening again. Zotac never succeeds, it just continues saying CLOUDFLARE WAITING or LIMIT REACHED. But loading the page manually shows it will load after several seconds. My PAGE_TIMEOUT is set to 45000. |
|
can confirm, this wont work no matter the settings still. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… when it never progresses past its DDoS protection page
Description
Fixes #1459
Fixes #1490
Sometimes (particularly with certain user-agents) Cloudflare will infinitely redirect you to another DDoS protection page; this can lead to infinite recursion. This change aborts after being forwarded 5 times.
Testing
Merge, set STORE=zotac, then "npm start run" until seeing "CLOUDFLARE RECURSION LIMIT REACHED, ABORTING"
New dependencies
None