Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.7.0 Nvidia Deprecation Notices #673

Closed
xcharlesy opened this issue Nov 3, 2020 · 4 comments · Fixed by #1209
Closed

1.7.0 Nvidia Deprecation Notices #673

xcharlesy opened this issue Nov 3, 2020 · 4 comments · Fixed by #1209
Labels
priority: low status: stale type: feature

Comments

@xcharlesy
Copy link

warn :: nvidia is deprecated in favor of bestbuy

If I receive this new notice does this mean it is no longer checking nvidia and is instead only checking bestbuy?
@GoBLiN-aK
Copy link

I removed Nvidia from my store list because they are sending their stock to Best Buy. If you check the Nvidia website, you can see that they are showing what other retailers you can buy their cards at.

@xcharlesy
Copy link
Author

I removed Nvidia from my store list because they are sending their stock to Best Buy. If you check the Nvidia website, you can see that they are showing what other retailers you can buy their cards at.

Didn't the official communication from Nvidia state that they are "working to improve the experience"? I took that as a temporary measure.

Additionally, they also say "In Europe, we will restart fulfilment of Founders Edition products in the coming days and plan to expand our country coverage in due course" - since nvidia-snatcher supports many countries wouldn't this create an issue if you are trying to shop Nvidia exclusively for a FE card? For example, I have changed my country selection to Canada as a test and it still uses the deprecation notice even though the FE card can't be purchased by Best Buy Canada.

Would like to confirm if all of the above is working as intended.

@jef
Copy link
Owner

jef commented Nov 3, 2020 •
edited
Loading

Good question! This deprecation notice is only a notice, it won't stop the functionality.

And for future reference, when usually you see 'deprecated` functionality, it just means that it's there, but may not be working or perhaps no longer updated.

In this case, it works, but do not know of the outcome.

That being said...

For example, I have changed my country selection to Canada as a test and it still uses the deprecation notice even though the FE card can't be purchased by Best Buy Canada.

I should update the notice only for US stores. Thank you!

@jef jef mentioned this issue Nov 3, 2020
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2020

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

jef added a commit that referenced this issue Dec 6, 2020
@jef
fix(nvidia): deprecation notice removed outside of usa
d741578 
Resolves #673
@jef jef mentioned this issue Dec 6, 2020
Merged
@jef jef closed this as completed in #1209 Dec 6, 2020
jef added a commit that referenced this issue Dec 6, 2020
@jef
feat(notification): add price to links (#1209)
15ec12b 
fix(store): label selection ordering and pricing
fix(nvidia): deprecation notice removed outside of usa
fix(amazon): maxPrice selector

Resolves #1188
Resolves #673
Resolves #1187
@github-actions github-actions bot mentioned this issue Oct 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: low status: stale type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(notification): add price to links jef/streetmerchant
3 participants
@xcharlesy @jef @GoBLiN-aK