Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated/missing store.asus.com links #1637

Closed
JesterEE opened this issue Jan 8, 2021 · 3 comments
Closed

Outdated/missing store.asus.com links #1637

JesterEE opened this issue Jan 8, 2021 · 3 comments

Comments

@JesterEE
Copy link
Contributor

JesterEE commented Jan 8, 2021

Expected Behavior

Query and report on stock of 30 series cards from store.asus.com

Current Behavior

3060ti, 3070 cards are not present. 3080 and 3090 series card links are missing or outdated.

Other

I created a feature branch to fix this, however I am not operating a development environment for this project and have no good way to test it for pull. I request that @jef or one of the other project developers review the branch and pull/implement the updates I made to enhance streetmerchant.

JesterEE/streetmerchant@d04ba972c49e3e6f1371ccea9eee15b3a2b6a18c

@wofnull
Copy link
Contributor

wofnull commented Jan 8, 2021

you can open a pull request from your repo on github from within the branch with the regarding changes.

So jef can implement this directly, if the branch with the asus fix works on your end and is tested / runs through the github pretests, jef can directly import it on your behalf.

@kiowadriver
Copy link

kiowadriver commented Jan 8, 2021

I tested the changes he made and they work if you also ensure you have added the "ko oc" model to the store.ts file as well.

@JesterEE
Copy link
Contributor Author

JesterEE commented Jan 9, 2021

@wofnull @kiowadriver
Thanks for helping with the testing! I will submit it as a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants