Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positives for mediamarkt.de and saturn.de #1545

Closed
YoBii opened this issue Dec 29, 2020 · 4 comments · Fixed by #1549
Closed

False positives for mediamarkt.de and saturn.de #1545

YoBii opened this issue Dec 29, 2020 · 4 comments · Fixed by #1549

Comments

@YoBii
Copy link

YoBii commented Dec 29, 2020

Expected Behavior

Vendors do not have the card in stock. No notification or alert should occur.

Current Behavior

Streetmerchant alerts about the item being in stock while it's actually not.
The problem has just recently started to occur. Like an hour ago. Before that it was working as expected.

Steps to Reproduce

Example link: https://www.mediamarkt.de/de/product/-2681866.html

Run streetmerchant with one of those shops active.
See screenshots attached

success-1609248769113
success-1609248770197

@Pexa-bot
Copy link

same here

@carrierfry
Copy link
Contributor

Same for me. Maybe they both changed their Website Layout (e.g. other ids for divs etc.?)

@wofnull
Copy link
Contributor

wofnull commented Dec 29, 2020

The layout of the site changed. Aswell as the report back itself, fixxed the problem in the meantime. You need just to modify both files in streetmerchant-main/src/store/model/ :
saturn.ts:
Simply add following after } in Line 23:

  	,
  	{
  		container: '#root',
  		text: ['Nicht verfügbar']
  	},
  	{
  		container: '#root',
  		text: ['Dieser Artikel ist dauerhaft ausverkauft']
  	}

mediamarkt.ts:
Simply add following after } in Line 23:

  	,
  	{
  		container: '#root',
  		text: ['Nicht verfügbar']
  	},
  	{
  		container: '#root',
  		text: ['Dieser Artikel ist dauerhaft ausverkauft']
  	}

This fixxes the false positives for now and makes the script working for Mediamarkt / Saturn site again.

@HebelHuber
Copy link

HebelHuber commented May 5, 2021

Im, getting false positives on mediamarkt again.
I checked the mentioned files and they have all the outOfStock entries (latest version on main).

Also, the price check seems to not work on mediamarkt, means false positives for price too high and out of stock.

edit:
nevermind, i found the correct issue: #2488

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants