Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(notification): add price to links #1209

Merged
merged 4 commits into from
Dec 6, 2020
Merged

feat(notification): add price to links #1209

merged 4 commits into from
Dec 6, 2020

Conversation

jef
Copy link
Owner

@jef jef commented Dec 5, 2020 •
edited
Loading

Description

Resolves #1188
Resolves #673
Resolves #1187

  • Gives the ability to put price into notifications (and potentially other places?)
  • Update Discord notification information
  • Resolves issue that did not let users know why it's out of stock (captcha or banned seller)
  • Update amazon's test item
  • Update amazon's price selector
  • Remove deprecation notice for nvidia outside of USA
    • Unsure if nvidia is actually superseded by bestbuy

Testing

image

image

New dependencies

  • Removed discord-webhook-node in favor of more popular library discord.js

@jef jef mentioned this pull request Dec 5, 2020
Closed
@jef jef merged commit 15ec12b into main Dec 6, 2020
@jef jef deleted the feat/link-price branch December 6, 2020 04:23
@github-actions github-actions bot mentioned this pull request Oct 21, 2022
Closed
@vutting4221 vutting4221 mentioned this pull request Nov 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@jef