Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amazon.DE false Alarms #1132

Closed
gigi2006 opened this issue Dec 3, 2020 · 14 comments · Fixed by #1183
Closed

amazon.DE false Alarms #1132

gigi2006 opened this issue Dec 3, 2020 · 14 comments · Fixed by #1183
Assignees

Comments

@gigi2006
Copy link

gigi2006 commented Dec 3, 2020

at Amazon.DE there are many false alarms.
the problem is that Amazon probably redirects automatically from the PS5 console to the controller and then the crawler here thinks that this is still the console.

is there a way to correct this?

@Nuggzan
Copy link

Nuggzan commented Dec 3, 2020

i never had a false alarm at amazon-de

@gigi2006
Copy link
Author

gigi2006 commented Dec 3, 2020

i never had a false alarm at amazon-de

I have only today 20-30

//edit: here a screenshot that automaticly
//edit2: sorry my english is just bad.
you can see a controller on the picture. this is because Amazon redirects the link of the console to the controller when there is a lot of traffic.

success-1606982709292

@jef
Copy link
Owner

jef commented Dec 3, 2020

This is a side effect of the playstation's link, as they have no direct link to the console.

Feel free to change your IN_STOCK_WAIT_TIME="" variable to something else so you don't get alerted repeatedly. The value is in milliseconds.

@jef jef closed this as completed Dec 3, 2020
@jef jef reopened this Dec 3, 2020
@jef
Copy link
Owner

jef commented Dec 3, 2020

Perhaps this can be fixed by adding another label helper to confirm that it's the item we're looking for. I'll keep this open for now.

@gigi2006
Copy link
Author

gigi2006 commented Dec 3, 2020

Perhaps this can be fixed by adding another label helper to confirm that it's the item we're looking for. I'll keep this open for now.

Thank you Jef :)

I really have to thank you again, with this tool I was able to buy what I was looking for a long time...

@jef
Copy link
Owner

jef commented Dec 3, 2020

That's awesome to hear!

@jef
Copy link
Owner

jef commented Dec 5, 2020

Take a look at that PR and let me know if that looks good (in terms of what the text should say).

@jef jef closed this as completed in #1183 Dec 5, 2020
jef added a commit that referenced this issue Dec 5, 2020
@gigi2006
Copy link
Author

gigi2006 commented Feb 2, 2021

@jef Hey bro, the problem we have unfortunately now at amazon.fr and I think also at amazon.es... today for example I get for the 100th time the notification that at amazon.fr the PS5 is available, but unfortunately it is only a redirect to the controller.

do you think your fix from amazon.de is also applicable to the other.

@jef
Copy link
Owner

jef commented Feb 2, 2021

Unfortunately there isn't a fix for this. You'll have to disable those sites until they get the URLs properly adjusted.

Or you can update your in stock notification to only notify you every hour or so, so you don't get bombarded with notifications.

@gigi2006
Copy link
Author

gigi2006 commented Feb 2, 2021

Unfortunately there isn't a fix for this. You'll have to disable those sites until they get the URLs properly adjusted.

Or you can update your in stock notification to only notify you every hour or so, so you don't get bombarded with notifications.

the problem is if i reduce it i'm scared of missing it. maybe an idea would be to specify the minimum price. So I would start with the ps5 350 and so I would not get a notification for the controller that only costs 80 €. just don't know how difficult that is to implement.

#1860 is the same Problem

@ithahn
Copy link

ithahn commented Feb 2, 2021

MIN_PRICES_SERIES could help?!

@gigi2006
Copy link
Author

gigi2006 commented Feb 2, 2021

MIN_PRICES_SERIES could help?!

Do you believe me that I haven't seen Min Price the whole time.

@jef
Copy link
Owner

jef commented Feb 2, 2021

MIN_PRICES_SERIES could help?!

Do you believe me that I haven't seen Min Price the whole time.

Haha, well it's not a thing so no need to worry! That being said, we could definitely add this in. I personally have more priority to refactor some of the config in general, but I don't mind if someone takes the time to add this in!

@Sly8383
Copy link

Sly8383 commented Feb 2, 2021

Thank you for the awsome job jf.

Any idea where we can add the Min_price parametr ?
I'm facing the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants