refactor: simplify maxPrice logic

Ref: 9b02c36, #2057
jef · Apr 9, 2021 · a25b7f1 · a25b7f1
1 parent e006c48
commit a25b7f1
Showing 1 changed file with 8 additions and 25 deletions.
diff --git a/src/store/lookup.ts b/src/store/lookup.ts
@@ -407,26 +407,6 @@ async function checkIsCloudflare(store: Store, page: Page, link: Link) {
   return false;
 }
 
-async function isAboveMaxPrice(
-  store: Store,
-  page: Page,
-  link: Link,
-  options: Selector
-): Promise<boolean> {
-  if (store.labels.maxPrice) {
-    const maxPrice = config.store.maxPrice.series[link.series];
-
-    link.price = await getPrice(page, store.labels.maxPrice, options);
-
-    if (link.price && link.price > maxPrice && maxPrice > 0) {
-      logger.info(Print.maxPrice(link, store, maxPrice, true));
-      return true;
-    }
-  }
-
-  return false;
-}
-
 async function isItemInStock(store: Store, page: Page, link: Link) {
   const baseOptions: Selector = {
     requireVisible: false,
@@ -469,10 +449,6 @@ async function isItemInStock(store: Store, page: Page, link: Link) {
       logger.info(Print.outOfStock(link, store, true));
       return false;
     }
-
-    if (await isAboveMaxPrice(store, page, link, options)) {
-      return false;
-    }
   }
 
   if (store.labels.inStock) {
@@ -486,8 +462,15 @@ async function isItemInStock(store: Store, page: Page, link: Link) {
       logger.info(Print.outOfStock(link, store, true));
       return false;
     }
+  }
 
-    if (await isAboveMaxPrice(store, page, link, options)) {
+  if (store.labels.maxPrice) {
+    const maxPrice = config.store.maxPrice.series[link.series];
+
+    link.price = await getPrice(page, store.labels.maxPrice, baseOptions);
+
+    if (link.price && link.price > maxPrice && maxPrice > 0) {
+      logger.info(Print.maxPrice(link, store, maxPrice, true));
       return false;
     }
   }