Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

:BuffergatorMruCyclePrev and ...Next doesn't cycle through global MRU list when g:buffergator_mru_cycle_local_to_window is set to 0 #84

Open
automotua opened this issue Mar 8, 2018 · 6 comments
Open

:BuffergatorMruCyclePrev and ...Next doesn't cycle through global MRU list when g:buffergator_mru_cycle_local_to_window is set to 0 #84

automotua opened this issue Mar 8, 2018 · 6 comments

Comments

@automotua
Copy link
Contributor

When g:buffergator_mru_cycle_local_to_window is set to 0, I expect :BuffergatorMruCyclePrev and : BuffergatorMruCycleNext should also cycle through the global MRU list, instead of the window one. It does not behave in this way right now.

I suspect it might be a bug instead of an intended behavior, and I've got a PR to fix it.
automotua added a commit to automotua/vim-buffergator that referenced this issue Mar 17, 2018
@automotua
Fixed Issue jeetsukumaran#84
3d05e66 
Issue jeetsukumaran#84 of the 'jeetsukumaran/vim-buffergator' is here:
jeetsukumaran#84

Pass the MRU list to s:_find_mru_bufnr and let it use this list instead
of the window list. This list has already been decided whether it's
global or window list before it's passed.
@automotua
Copy link
Contributor Author

Don't think this repo is still being maintained. I forked my own version with the fix. Here: https://github.com/automotua/vim-buffergator

@automotua automotua reopened this Mar 17, 2018
@automotua
Copy link
Contributor Author

Actually, I'd like to keep it open and see if anyone will still come back and see this.

@jeetsukumaran
Copy link
Owner

I have not had time to review your PR over the last couple of weeks. I will look at it when I get the time.

automotua added a commit to automotua/vim-buffergator that referenced this issue Mar 17, 2018
@automotua
Fixed Issue jeetsukumaran#84
ae7252d 
Pass the MRU list to s:_find_mru_bufnr and let it use this list instead
of the window list. This list has already been decided whether it's
global or window list before it's passed.
automotua added a commit to automotua/vim-buffergator that referenced this issue Mar 17, 2018
@automotua
Fixed Issue jeetsukumaran#84
1004ebc 
Pass the MRU list to s:_find_mru_bufnr and let it use this list instead
of the window list. This list has already been decided whether it's
global or window list before it's passed.
@automotua
Copy link
Contributor Author

Cool. I've just created the PR: #85

@jeetsukumaran
Copy link
Owner

Thanks. I will look at it when I can. I am afraid that it will be later rather than sooner due to other commitments right now.

@automotua
Copy link
Contributor Author

automotua commented Mar 19, 2018 via email

jeetsukumaran added a commit that referenced this issue May 2, 2018
@jeetsukumaran
Merge pull request #85 from automotua/master
947b60d 
Fixed Issue #84
@oryband oryband mentioned this issue Nov 5, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeetsukumaran @automotua