Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib): Manim fixes, bump to >= 0.18, and tests #447

Merged
merged 26 commits into from
Jul 1, 2024
Merged

Conversation

jeertmans
Copy link
Owner

@jeertmans jeertmans commented Jun 12, 2024

This PR bumps Manim to >= 0.18 because it is a pain to have to support both the old colors and the new color system.

Tests are also refactored so that they actually test for ManimGL and OpenGL renderers too.

TODO:

  • Add in the docs a note about ManimGL and ManimCE be installable altogether (because manimpango and NumPy)
  • Also, ManimGL extra is not available on Python >= 3.12, because it is broken with Numpy > 1.24
  • Finish cleaning tests

Unfortunately, Rye uses an outdated version of uv, and we need to have at least uv>=0.2.6 to support the dependency overrides.

Closes #431

@jeertmans jeertmans added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Jun 12, 2024
@jeertmans jeertmans marked this pull request as draft June 12, 2024 11:50
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.37%. Comparing base (5924c32) to head (50faf16).
Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #447      +/-   ##
==========================================
+ Coverage   79.24%   80.37%   +1.13%     
==========================================
  Files          22       22              
  Lines        1816     1824       +8     
==========================================
+ Hits         1439     1466      +27     
+ Misses        377      358      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeertmans jeertmans marked this pull request as ready for review July 1, 2024 14:56
@jeertmans jeertmans merged commit e2d8c56 into main Jul 1, 2024
5 of 8 checks passed
@jeertmans jeertmans deleted the fix-config branch July 1, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 'OpenGLCamera' object has no attribute 'background_color' when rendering using manim.opengl
1 participant