progress: fix incorrect mutex usages #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Worth noting that the only reason tests are failing is because of coveralls doesn't seem to be configured properly. |
|
Thanks for the change. Will look into it this week. I've to figure out a way forward for coveralls with GitHub Actions. |
|
@virtuald The changes look okay to me. Can you rebase to latest on the master branch? |
- tracker.mutexPrv is useless since it only protects writes. Removed it. - Remove usages of tracker.mutex outside of the tracker object, ensures usage is more obviously correct - Fix race condition that occurred when generating the tracker string
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran the demo with the race detector several times and wasn't able to duplicate the race found in https://github.com/jedib0t/go-pretty/pull/153/checks?check_run_id=2266140256, but it seems pretty obvious that this is the culprit.