Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export env vars from config #37

Closed
wants to merge 1 commit into from
Closed

Conversation

reitzig
Copy link

@reitzig reitzig commented Feb 4, 2024

sketches fix for #36

I don't speak JS/TS and don't even have a running developer environment; these are just some doodles. Can you take over, @jdx ? 🙏

I notice that the action currently uses shims; seems to me we could use PATH from mise env instead? Then we'd probably have to split setEnvVars and run mise env after mise install? 🤔

@jdx
Copy link
Owner

jdx commented Feb 4, 2024

It uses shims so it can use config files from sub-directories.

@reitzig
Copy link
Author

reitzig commented Apr 23, 2024

@jdx , is this something that can be expanded into a proper fix for #36, or can we scrap it?

@GreyTeardrop
Copy link

Would be really great to have this.
I believe if we run mise --env after mise install, we should be able to also export tool-specific environment variables. For us, that would help with setting proper JAVA_HOME when installing Java via mise-action.

@jdx jdx closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants