fix(mrml-core): add missing attributes in mj-accordion-text and mj-button #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinanguyen
force-pushed
the
my-patched-version
branch
from
518f7b7 to
59c4e3c
Compare
jdrouet
force-pushed
the
my-patched-version
branch
from
59c4e3c to
e8fe78b
Compare
jdrouet
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #513 +/- ##
==========================================
- Coverage 92.89% 92.43% -0.46%
==========================================
Files 227 201 -26
Lines 12203 12334 +131
==========================================
+ Hits 11336 11401 +65
- Misses 867 933 +66 ☔ View full report in Codecov by Sentry. |
Signed-off-by: austin <austinanguyenwork@gmail.com>
Signed-off-by: austin <austinanguyenwork@gmail.com>
jdrouet
force-pushed
the
my-patched-version
branch
from
e8fe78b to
b9b96fd
Compare
Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mj-accordion-text was missing letter-spacing and font-weight. mj-button was missing font-weight. Now supports rendering these attributes. https://documentation.mjml.io/#mj-button, https://documentation.mjml.io/#mj-accordion