-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: node_modules will be searched when detecting configuration #229
Conversation
This pull request introduces 1 alert when merging fcddcd9 into 7923914 - view on LGTM.com new alerts:
Warning - Automated code review for jdneo/vscode-checkstyle will be disabled on October 1, 2019. You can avoid this by installing the LGTM.com GitHub App. Read about the benefits of migrating to GitHub Apps in the blog. Comment posted by LGTM.com |
fcddcd9
to
a420570
Compare
This pull request introduces 1 alert when merging a420570 into 7923914 - view on LGTM.com new alerts:
Warning - Automated code review for jdneo/vscode-checkstyle will be disabled on October 1, 2019. You can avoid this by installing the LGTM.com GitHub App. Read about the benefits of migrating to GitHub Apps in the blog. Comment posted by LGTM.com |
This alert could be dismissed, as it is the error message |
This pull request introduces 1 alert when merging d8a8fab into d9dc7a9 - view on LGTM.com new alerts:
Warning - Automated code review for jdneo/vscode-checkstyle will be disabled on October 1, 2019. You can avoid this by installing the LGTM.com GitHub App. Read about the benefits of migrating to GitHub Apps in the blog. Comment posted by LGTM.com |
This pull request introduces 1 alert when merging b1f675f into d9dc7a9 - view on LGTM.com new alerts:
Warning - Automated code review for jdneo/vscode-checkstyle will be disabled on October 1, 2019. You can avoid this by installing the LGTM.com GitHub App. Read about the benefits of migrating to GitHub Apps in the blog. Comment posted by LGTM.com |
Fix #242
workspace.findFiles
by default will NOT excludenode_modules
, because it only usesfiles.exclude
setting, wherenode_modules
is insearch.exclude
and.gitignore
.files.exclude
,search.exclude
and.gitignore
, like Revamp findFiles microsoft/vscode#48674 (comment)