Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: node_modules will be searched when detecting configuration #229

Merged
merged 5 commits into from
Sep 25, 2019

Conversation

Vigilans
Copy link
Collaborator

@Vigilans Vigilans commented Sep 24, 2019

Fix #242

workspace.findFiles by default will NOT exclude node_modules, because it only uses files.exclude setting, where node_modules is in search.exclude and .gitignore.

@Vigilans Vigilans closed this Sep 24, 2019
@Vigilans Vigilans reopened this Sep 24, 2019
@jdneo
Copy link
Owner

jdneo commented Sep 24, 2019

This pull request introduces 1 alert when merging fcddcd9 into 7923914 - view on LGTM.com

new alerts:

  • 1 for Template syntax in string literal

Warning - Automated code review for jdneo/vscode-checkstyle will be disabled on October 1, 2019. You can avoid this by installing the LGTM.com GitHub App. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

@jdneo
Copy link
Owner

jdneo commented Sep 24, 2019

This pull request introduces 1 alert when merging a420570 into 7923914 - view on LGTM.com

new alerts:

  • 1 for Template syntax in string literal

Warning - Automated code review for jdneo/vscode-checkstyle will be disabled on October 1, 2019. You can avoid this by installing the LGTM.com GitHub App. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

@Vigilans
Copy link
Collaborator Author

Vigilans commented Sep 24, 2019

This pull request introduces 1 alert when merging a420570 into 7923914 - view on LGTM.com

new alerts:

  • 1 for Template syntax in string literal

Warning - Automated code review for jdneo/vscode-checkstyle will be disabled on October 1, 2019. You can avoid this by installing the LGTM.com GitHub App. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

This alert could be dismissed, as it is the error message 'workspaceFolder not loaded when ${workspaceFolder} is present'.

@Vigilans Vigilans changed the title fix: Configuration xml detection fix: node_modules will be searched when detecting configuration Sep 25, 2019
@jdneo jdneo added this to the 1.3.0 milestone Sep 25, 2019
@jdneo
Copy link
Owner

jdneo commented Sep 25, 2019

This pull request introduces 1 alert when merging d8a8fab into d9dc7a9 - view on LGTM.com

new alerts:

  • 1 for Template syntax in string literal

Warning - Automated code review for jdneo/vscode-checkstyle will be disabled on October 1, 2019. You can avoid this by installing the LGTM.com GitHub App. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

@jdneo
Copy link
Owner

jdneo commented Sep 25, 2019

This pull request introduces 1 alert when merging b1f675f into d9dc7a9 - view on LGTM.com

new alerts:

  • 1 for Template syntax in string literal

Warning - Automated code review for jdneo/vscode-checkstyle will be disabled on October 1, 2019. You can avoid this by installing the LGTM.com GitHub App. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

@Vigilans Vigilans added the bug label Sep 25, 2019
@jdneo jdneo merged commit 767e77c into master Sep 25, 2019
@jdneo jdneo deleted the vigilans/xml-findFiles branch September 25, 2019 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node_modules will be searched when detecting configuration
2 participants