Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revive HTML example #16

Merged
merged 2 commits into from
Dec 31, 2020
Merged

Revive HTML example #16

merged 2 commits into from
Dec 31, 2020

Conversation

curran
Copy link
Contributor

@curran curran commented Dec 30, 2020 •
edited
Loading

Closes #11

@curran curran changed the title Revive miserables example Revive HTML example Dec 30, 2020
@curran
Copy link
Contributor Author

curran commented Dec 30, 2020 •
edited
Loading

One odd thing I notice is that the http://127.0.0.1:8080/examples/bertin/ example invokes the global distance() as a function. I'm not sure where this is supposed to come from.

The other examples all appear to be revived.

@curran
Copy link
Contributor Author

curran commented Dec 30, 2020

Ready for review @jdfekete @Fil. Thanks!

@jdfekete jdfekete merged commit c868ff4 into jdfekete:master Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix HTML Examples
2 participants
@curran @jdfekete