Skeleton 骨架屏代码提交 #96
Merged
Skeleton 骨架屏代码提交 #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oasis-cloud
requested changes
Mar 4, 2022
| ) | ||
| } | ||
| export default App; | ||
| ``` |
There was a problem hiding this comment.
这里需要加 ::: 来结束 demo 块，每个 demo 块都是如此，目前 React 库采用的包和 Vue 的有区别，Vue 的对未结束的识别不出来
src/packages/skeleton/skeleton.tsx
Outdated
| ></div> | ||
| ) : ( | ||
| <div className="content-line"> | ||
| {title && <div className="title"></div>} |
There was a problem hiding this comment.
className="title" 存在全局样式污染的可能，遵守 BEM 规范
irisSong
reviewed
Mar 4, 2022
src/packages/skeleton/skeleton.tsx
Outdated
| for (let i = 0; i < num; i++) { | ||
| items.push(i) | ||
| } | ||
| return items |
There was a problem hiding this comment.
66-70，可修改为
return Array.from({ length: num-1 }, (v, i) => i)
oasis-cloud
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
已自测
文档已开发