refactor: dialog #945
Merged
refactor: dialog #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oasis-cloud
reviewed
Apr 25, 2023
src/packages/dialog/DialogWrap.tsx
Outdated
| import Mask from './Mask' | ||
| import { OverlayProps, defaultOverlayProps } from '@/packages/overlay/overlay' | ||
| import { ComponentDefaults } from '@/utils/typings' | ||
| import Overlay from '@/packages/overlay' |
There was a problem hiding this comment.
公共的 dialogWrap 需要考虑 taro 版本和 H5 版本的差异。这里引入的 overlay 是 H5的。还是建议分开处理
There was a problem hiding this comment.
overlay 组件的有些问题，先改overlay，然后调整。
oasis-cloud
reviewed
Apr 25, 2023
src/packages/dialog/doc.en-US.md
Outdated
| | confirmText | Confirm the button copywriting| ReactNode | `Sure` | | ||
| | cancelText | Cancellation of buttons | ReactNode | `Cancel` | | ||
| | overlay | Whether to show a overlay | boolean | `true` | | ||
| | hideConfirmButton| Whether to hide the OK button | boolean | `false` | |
There was a problem hiding this comment.
文档中的类型建议加上 ``,例如 boolean 改为 boolean
src/packages/dialog/doc.md
Outdated
| @@ -42,7 +42,7 @@ const App = () => { | |||
| Dialog.alert({ | |||
| title: '温馨提示', | |||
| content: '支持函数调用和组件调用两种方式。', | |||
| noCancelBtn: true | |||
| hideCancelButton: true | |||
There was a problem hiding this comment.
文档中的 demo 建议和 demo 保持一致，这样开发者读文档比较容易对应上
Closed
oasis-cloud
reviewed
Apr 28, 2023
src/packages/dialog/DialogWrap.tsx
Outdated
| onCancel, | ||
| onClickOverlay, |
There was a problem hiding this comment.
改成 onOverlayClick 和 closeOnOverLay 保持一致
src/packages/dialog/DialogWrap.tsx
Outdated
| const wrapStyle = { | ||
| ...style, | ||
| display: visible ? 'block' : 'none', | ||
| const overlayStyles = { |
src/packages/dialog/config.ts
Outdated
| onCancel?: () => void | ||
| onClickSelf?: () => void | ||
| beforeClose?: () => void | ||
| beforeCancel?: () => void |
There was a problem hiding this comment.
类型不对吧，应该改成 () => boolean
oasis-cloud
approved these changes
Apr 28, 2023
| @@ -16,7 +16,7 @@ interface DialogWrapProps extends OverlayProps { | |||
| footer: React.ReactNode | |||
| onCancel: () => void | |||
| onClose: () => void | |||
| onClickOverlay: (e: MouseEvent) => boolean | void | |||
| onOverlayClick: (e: MouseEvent) => boolean | void | |||
There was a problem hiding this comment.
这个类型要改成 boolean | void
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个变动的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
☑️ 请求合并前的自查清单