refactor: progress #943
Merged
refactor: progress #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oasis-cloud
reviewed
Apr 25, 2023
| | --nutui-progress-large-text-top | `$progress-insidetext-top` | | ||
| | 名称 | 说明 | 默认值 | | ||
| | --- | --- | --- | | ||
| | --nutui-progress-height | 进度条宽度 | `10px` | |
oasis-cloud
approved these changes
Apr 25, 2023
xiaoyatong
reviewed
Apr 25, 2023
src/packages/progress/progress.tsx
Outdated
| textType: TextType | ||
| status: boolean | ||
| icon: ReactNode | ||
| animated: boolean | ||
| children: ReactNode |
There was a problem hiding this comment.
BasicComponent 里有 children ，可不要。
| textType: TextType | ||
| status: boolean | ||
| icon: ReactNode | ||
| animated: boolean | ||
| children: ReactNode |
There was a problem hiding this comment.
BasicComponent 里已有children~
xiaoyatong
reviewed
Apr 25, 2023
migrate-from-v1.md
Outdated
| - strokeColor 重命名为 color | ||
| - fillColor 重命名为 background | ||
| - 移除 size，通过 strokeWidth、css 变量实现尺寸自定义 | ||
| - status 重命名为 animated |
There was a problem hiding this comment.
建议说明一下 为什么重命名为 animated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.