-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: overlay(v2.0) #886
Changes from all commits
38b995e
a160a68
fa4cd0b
a73bdfb
b72d792
7052fc2
d47fd96
9e165e3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -202,4 +202,4 @@ | |
"@types/react": "18", | ||
"@types/react-dom": "18" | ||
} | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -146,11 +146,11 @@ export const MenuItem = forwardRef((props: Partial<MenuItemProps>, ref) => { | |
onClick={() => parent.toggleItemShow(orderKey)} | ||
/> | ||
<Overlay | ||
overlayClass="nut-menu__overlay" | ||
className="nut-menu__overlay" | ||
style={getPosition()} | ||
lockScroll={parent.lockScroll} | ||
visible={_showPopup} | ||
closeOnClickOverlay={parent.closeOnClickOverlay} | ||
closeOnOverlayClick={parent.closeOnClickOverlay} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. parent.closeOnClickOverlay 这个顺便改了吧,改成一致的。 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. menu 没有处理。 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 这个closeOnClickOverlay是MenuProps的一个属性,这个在开发menu组件的时候再修改即可。 |
||
onClick={() => { | ||
parent.closeOnClickOverlay && parent.toggleItemShow(orderKey) | ||
}} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
提出 classprefix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个在开发menu组件的时候再自行提取classprefix即可。