refactor: pagination #861
Merged
refactor: pagination #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoyatong
reviewed
Apr 11, 2023
src/packages/pagination/doc.en-US.md
Outdated
| | pageSize | records per page | string \| number | `10` | | ||
| | itemSize | number of pages displayed | string \| number | `5` | | ||
| | ellipse | Whether to show ellipsis | boolean | `false` | | ||
| | itemRender | Used to customize page number content | (page) => ReactNode | - | | ||
|
|
||
| ### Events |
| @@ -75,7 +69,7 @@ export const Pagination: FunctionComponent< | |||
| if (mode === 'simple') return [] | |||
| const items = [] | |||
| const pageCount = _countRef || countRef // 总的页面数量 | |||
| const pageSize = Number(showPageSize) // 展示的页面个数 | |||
| const pageSize = Number(itemSize) // 展示的页面个数 | |||
| const _current = _currentPage || Number(currentPage) // 当前页 | |||
There was a problem hiding this comment.
current 的命名是否可以去掉，另Number()，是否不需要，currentPage 默认是否为 number类型了？
oasis-cloud
reviewed
Apr 17, 2023
| @@ -40,6 +40,16 @@ | |||
| #### Menu | |||
| #### NavBar | |||
| #### Pagination | |||
| - modelValue 改为 current，受控值 | |||
| - 增加 defaultValue 非受控值 | |||
There was a problem hiding this comment.
pagination 组件的 defaultValue 是不是改成 defaultCurrent ，和 current 对应
xiaoyatong
reviewed
Apr 17, 2023
| ce5c5446: '基础用法', | ||
| c38a08ef: '简单模式', | ||
| b840c88f: '显示省略号', | ||
| a74a1fd4: '自定义按钮', |
| const c = v | ||
| setCurrent1(c) | ||
| } | ||
| const pageChange2 = (v: any) => { | ||
| const pageChange2 = (v: number) => { |
| </Cell> | ||
| <h2>{translated.uncontrolled}</h2> | ||
| <Cell> | ||
| <Pagination |
xiaoyatong
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1、modelValue -> current，受控
2、defaultValue 非受控，增加 demo
3、prevText -> prev
4、nextText -> next
5、forceEllipses -> ellipse
6、showPageSize -> itemSize
7、itemsPerpage -> pageSize
8、totalitems -> total
9、pageNodeRender -> itemRender
10、移除 pageCount
11、增加受控与非受控方式的单元测试