-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Uploade 组件无法预览图片 #2822
fix: Uploade 组件无法预览图片 #2822
Conversation
Walkthrough此次更改主要集中在 Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
src/packages/uploader/uploader.scss (1)
181-182
: 使用 CSS 变量优化图片预览尺寸控制这个改动通过引入 CSS 变量来控制预览图片的尺寸是很好的做法。建议在组件文档中添加这些新的 CSS 变量的使用说明。
示例文档:
## CSS 变量 | 变量名 | 默认值 | 说明 | | --- | --- | --- | | --nutui-uploader-image-width | 100px | 上传图片预览容器的宽度 | | --nutui-uploader-image-height | 100px | 上传图片预览容器的高度 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2822 +/- ##
=======================================
Coverage 84.07% 84.07%
=======================================
Files 217 217
Lines 17830 17830
Branches 2609 2609
=======================================
Hits 14991 14991
Misses 2834 2834
Partials 5 5 ☔ View full report in Codecov by Sentry. |
🤔 这个变动的性质是?
🔗 相关 Issue
#2821
💡 需求背景和解决方案
Uploade 组件无法预览图片
重新修改对应元素的宽高
☑️ 请求合并前的自查清单
Summary by CodeRabbit
新功能
样式
.nut-uploader-img-c
类的高度属性为宽度属性,使用CSS变量实现响应式设计。