chore: update icons-react-taro version #2706

irisSong · 2024-11-07T09:06:05Z

🤔 这个变动的性质是？

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

文档已补充或无须补充
代码演示已提供或无须提供
TypeScript 定义已补充或无须补充
fork仓库代码是否为最新避免文件冲突
Files changed 没有 package.json lock 等无关文件

Summary by CodeRabbit

新特性
- 更新了依赖项 @nutui/icons-react-taro 的版本，从 2.0.0-beta.0 升级为 ^2.0.0-beta.0，允许自动更新兼容的次要或补丁版本。

coderabbitai · 2024-11-07T09:06:11Z

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

@nutui/nutui-react-taro 项目的 package.json 文件进行了修改，主要是将依赖 @nutui/icons-react-taro 的版本从 2.0.0-beta.0 更新至 ^2.0.0-beta.0。此更改允许自动更新任何兼容的次要或补丁版本，表明了对版本管理方式的灵活调整。其他依赖、开发依赖、脚本或 package.json 文件的其他部分没有进行修改，整体结构和内容保持一致。

Changes

文件	更改摘要
package.json	更新依赖 `@nutui/icons-react-taro` 版本从 `2.0.0-beta.0` 到 `^2.0.0-beta.0`

Possibly related PRs

fix: remove icons defaultprops #2571: 此 PR 更新了 package.json 中的 @nutui/icons-react-taro 版本，直接与主 PR 中的版本更新相关。
fix(inputnumber): icon 适配 && 修改icon宽度和设定的--nut-icon-width一致 #2707: 此 PR 也更新了 package.json 中的 @nutui/icons-react-taro 版本，表明与主 PR 中的版本管理更改相关。
fix(cell): update Icon #2716: 此 PR 类似于主 PR，将 @nutui/icons-react-taro 的版本从固定版本更改为 caret 版本，符合主 PR 中引入的版本管理策略。

Suggested labels

size/XS, 2.x

Suggested reviewers

Alex-huxiyang
irisSong

Poem

在兔子洞里跳跃欢，
版本更新乐无边。
图标依赖新气象，
未来功能更辉煌。
跳跃吧，伙伴们，
一起迎接新篇章！ 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2024-11-07T09:07:29Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.95%. Comparing base (a291f58) to head (847c2ed).
Report is 2 commits behind head on V3.0.

Additional details and impacted files

@@           Coverage Diff           @@
##             V3.0    #2706   +/-   ##
=======================================
  Coverage   83.95%   83.95%           
=======================================
  Files         221      221           
  Lines       17849    17849           
  Branches     2679     2679           
=======================================
  Hits        14986    14986           
  Misses       2858     2858           
  Partials        5        5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

xiaoyatong · 2024-11-07T09:08:21Z

更新一下lock文件

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between a291f58 and 847c2ed.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (1)

package.json (1 hunks)

🔇 Additional comments (2)

package.json (2)

107-107: 建议检查相关依赖的兼容性

注意到：

@nutui/icons-react 仍然停留在 ^1.0.5
@nutui/jdesign-icons-react-taro 使用的是 1.0.6-beta.2

建议确认这些相关图标包之间的版本兼容性，以避免潜在的冲突。

#!/bin/bash
# 检查项目中是否同时使用了多个图标包
rg -l "@nutui/icons-react|@nutui/icons-react-taro|@nutui/jdesign-icons-react-taro"

107-107: ⚠️ Potential issue

需要注意重大版本更新的影响

将 @nutui/icons-react-taro 从 ^1.0.5 更新到 ^2.0.0-beta.0 是一个重大版本升级：

由于是主版本号升级（1.x → 2.x），可能包含破坏性更改
beta 版本可能存在不稳定性
建议：
- 查看更新日志了解具体的破坏性更改
- 在合并前进行充分的测试
- 考虑是否应该等待正式版本发布

coderabbitai · 2024-11-07T09:19:31Z

package.json

@@ -104,7 +104,7 @@
  "dependencies": {
    "@babel/runtime": "^7.23.9",
    "@nutui/icons-react": "^1.0.5",
-    "@nutui/icons-react-taro": "^1.0.5",
+    "@nutui/icons-react-taro": "^2.0.0-beta.0",


⚠️ Potential issue

需要更新 lock 文件

根据 PR 评论建议，请确保更新相应的 lock 文件（package-lock.json 或 yarn.lock）以锁定依赖版本。这对于确保所有开发者使用相同的依赖版本至关重要。

irisSong · 2024-11-07T11:12:29Z

更新一下lock文件

更新了

fix: update icons-react-taro version

d4adac8

pull-request-size bot added the size/XS label Nov 7, 2024

github-actions bot added the 3.x label Nov 7, 2024

chore: update pnpm-lock.yaml

847c2ed

pull-request-size bot added size/M and removed size/XS labels Nov 7, 2024

irisSong changed the title ~~fix: update icons-react-taro version~~ chore: update icons-react-taro version Nov 7, 2024

coderabbitai bot reviewed Nov 7, 2024

View reviewed changes

xiaoyatong closed this Nov 8, 2024

irisSong added 4 commits November 8, 2024 10:18

fix: 合并v3.0

a4f2168

fix: 合并v3.0

242373f

fix: 合并v3.0

634b3d4

fix: 合并3.0

1272891

xiaoyatong reopened this Nov 9, 2024

pull-request-size bot added size/S and removed size/M labels Nov 9, 2024

Merge branch 'V3.0' into 3.0

837ef46

pull-request-size bot added size/XS and removed size/S labels Nov 9, 2024

irisSong closed this Nov 9, 2024

irisSong deleted the 3.0 branch November 10, 2024 06:34

coderabbitai bot mentioned this pull request Dec 9, 2024

fix(countdown): update the v15 style #2843

Merged

20 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update icons-react-taro version #2706

chore: update icons-react-taro version #2706

irisSong commented Nov 7, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 7, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

codecov bot commented Nov 7, 2024 •

edited

Loading

xiaoyatong commented Nov 7, 2024

coderabbitai bot left a comment

coderabbitai bot Nov 7, 2024

irisSong commented Nov 7, 2024

chore: update icons-react-taro version #2706

chore: update icons-react-taro version #2706

Conversation

irisSong commented Nov 7, 2024 • edited by coderabbitai bot Loading

🤔 这个变动的性质是？

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

Summary by CodeRabbit

coderabbitai bot commented Nov 7, 2024 • edited Loading

Review skipped

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

codecov bot commented Nov 7, 2024 • edited Loading

Codecov Report

xiaoyatong commented Nov 7, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot Nov 7, 2024

Choose a reason for hiding this comment

irisSong commented Nov 7, 2024

irisSong commented Nov 7, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 7, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Nov 7, 2024 •

edited

Loading