feat(replace icon): 替换jmapp icon #2672
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| registry=https://registry.npmjs.org/ | ||
| engine-strict=true | ||
| strict-peer-dependencies=false | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,8 @@ | ||
| // babel-preset-taro 更多选项和默认值： | ||
| // https://github.com/NervJS/taro/blob/next/packages/babel-preset-taro/README.md | ||
| const replaceIcons = require('@nutui/replace-icons') | ||
| const projectID = process.env.VITE_APP_PROJECT_ID | ||
|
|
||
| module.exports = { | ||
| presets: [ | ||
| [ | ||
|
|
@@ -12,5 +15,11 @@ module.exports = { | |
| ], | ||
| plugins: [ | ||
| ['@babel/plugin-transform-typescript', { allowDeclareFields: true }], | ||
| projectID === 'jmapp' && [ | ||
| replaceIcons({ | ||
| sourceLibrary: ['@nutui/icons-react-taro', '@nutui/icons-react'], | ||
| targetLibrary: '@nutui/jdesign-icons-react-taro', | ||
| }), | ||
| ], | ||
| ].filter(Boolean), | ||
|
Comment on lines
+18
to
+24
There was a problem hiding this comment. 💡 Codebase verification 缺少必要的图标依赖项，需要添加相关依赖 检查结果显示，当前项目中缺少以下必要的依赖项：
虽然 建议在 package.json 中添加这些缺失的依赖项。 🔗 Analysis chain配置结构合理，建议验证依赖项 配置结构清晰，使用 filter(Boolean) 处理条件插件的方式很好。 请运行以下脚本验证相关依赖是否正确安装： 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# 验证所需依赖是否在 package.json 中定义
# 检查替换图标相关的依赖
jq -r '.dependencies | select(
has("@nutui/replace-icons") and
has("@nutui/icons-react-taro") and
has("@nutui/icons-react") and
has("@nutui/jdesign-icons-react-taro")
)' packages/nutui-taro-demo/package.json
Length of output: 217 Script: #!/bin/bash
# 让我们分别检查每个依赖项
echo "检查 package.json 中的依赖项:"
jq '.dependencies | {
"@nutui/replace-icons": .["@nutui/replace-icons"],
"@nutui/icons-react-taro": .["@nutui/icons-react-taro"],
"@nutui/icons-react": .["@nutui/icons-react"],
"@nutui/jdesign-icons-react-taro": .["@nutui/jdesign-icons-react-taro"]
}' packages/nutui-taro-demo/package.json
echo -e "\n检查 devDependencies 中的依赖项:"
jq '.devDependencies | {
"@nutui/replace-icons": .["@nutui/replace-icons"],
"@nutui/icons-react-taro": .["@nutui/icons-react-taro"],
"@nutui/icons-react": .["@nutui/icons-react"],
"@nutui/jdesign-icons-react-taro": .["@nutui/jdesign-icons-react-taro"]
}' packages/nutui-taro-demo/package.json
# 检查是否有相关的导入语句
echo -e "\n检查相关导入语句:"
rg -l "@nutui/(replace-icons|icons-react-taro|icons-react|jdesign-icons-react-taro)"
Length of output: 13533 |
||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,6 +45,7 @@ | |
| "author": "", | ||
| "dependencies": { | ||
| "@babel/runtime": "^7.23.9", | ||
| "@nutui/replace-icons": "^1.0.0", | ||
| "@nutui/touch-emulator": "^1.0.0", | ||
| "@pmmmwh/react-refresh-webpack-plugin": "0.5.10", | ||
| "@tarojs/components": "3.6.22", | ||
|
|
@@ -68,7 +69,6 @@ | |
| "react": "^18.2.0", | ||
| "react-dom": "^18.2.0", | ||
| "react-refresh": "^0.14.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@babel/core": "^7.23.9", | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
建议谨慎评估依赖版本选择
从 package.json 中可以看到项目已经在使用
@nutui/icons-react和@nutui/icons-react-taro的稳定版本（1.0.5）。新添加的@nutui/jdesign-icons-react-taro@1.0.6-beta.2是测试版本，建议：@nutui/jdesign-icons-react-taro发布正式版本后再引入🔗 Analysis chain
注意：使用测试版依赖可能存在风险
新添加的依赖
@nutui/jdesign-icons-react-taro当前使用的是测试版本 (1.0.6-beta.2)。在生产环境中使用测试版本可能会带来不稳定性。建议：🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 700
Script:
Length of output: 274