fix: i18n #2597

xiaoyatong · 2024-09-13T10:24:58Z

i18n 适配
去掉没必要的注释

Summary by CodeRabbit

新特性
- 增强了应用的本地化功能，支持更多语言的用户界面文本。
- 新增了编辑、重置、上传文件、旋转和选择图片等功能的本地化字符串。
样式
- 更新了上传文件按钮的标签，使其根据当前语言环境动态显示。
文档
- 修复了样式文件中的拼写错误，提升了注释的清晰度。

coderabbitai · 2024-09-13T10:25:19Z

Walkthrough

本次更改主要集中在增强应用程序的本地化能力，新增了多个字符串属性和翻译，以支持用户界面中的编辑、重置、上传文件和头像裁剪功能。此外，对一些组件的代码进行了清理，删除了冗余的注释，以提高代码的可读性和维护性。

Changes

文件路径	更改摘要
`src/locales/base.ts`	在 `BaseLang` 接口中添加了 `edit`、`reset`、`list` 和 `avatarCropper` 对象的属性。
`src/locales/en-US.ts`	在 `enUS` 本地化文件中添加了 `edit`、`reset`、`list`、`rotate` 和 `selectImage` 的字符串常量。
`src/locales/id-ID.ts`	在印尼语本地化文件中添加了 `edit`、`reset`、`list`、`rotate` 和 `selectImage` 的翻译。
`src/locales/tr-TR.ts`	在土耳其语本地化文件中添加了 `edit`、`reset`、`list`、`rotate` 和 `selectImage` 的翻译。
`src/locales/zh-CN.ts`	在简体中文本地化文件中添加了 `edit`、`reset`、`list`、`rotate` 和 `selectImage` 的字符串。
`src/locales/zh-TW.ts`	在繁体中文本地化文件中添加了 `edit`、`reset`、`list`、`rotate` 和 `selectImage` 的字符串。
`src/locales/zh-UG.ts`	在维吾尔语本地化文件中添加了 `edit`、`reset`、`list`、`rotate` 和 `selectImage` 的翻译。
`src/packages/address/address.taro.tsx`	删除了与地址选择相关的注释。
`src/packages/address/address.tsx`	删除了与地址选择相关的注释。
`src/packages/address/customRender.taro.tsx`	修改了 `visible` 属性的注释内容。
`src/packages/address/customRender.tsx`	修改了 `visible` 属性的注释内容。
`src/packages/address/types.ts`	删除了对 `Regions` 接口的注释。
`src/packages/avatar/avatar.tsx`	删除了描述头像折叠功能的注释。
`src/packages/avatarcropper/avatarcropper.taro.tsx`	引入了 `useConfig` 钩子以支持本地化，更新了按钮标签。
`src/packages/avatarcropper/avatarcropper.tsx`	引入了 `useConfig` 钩子以支持本地化，更新了按钮标签。
`src/packages/cascader/cascader.taro.tsx`	引入了 `useConfig` 钩子以支持本地化，更新了未选择节点时的提示文本。
`src/packages/cascader/cascader.tsx`	引入了 `useConfig` 钩子以支持本地化，更新了未选择节点时的提示文本。
`src/packages/collapseitem/collapseitem.taro.tsx`	删除了获取 DOM 元素的注释。
`src/packages/collapseitem/collapseitem.tsx`	删除了获取 DOM 元素的注释。
`src/packages/configprovider/configprovider.taro.tsx`	删除了创建 Context 对象的注释。
`src/packages/configprovider/configprovider.tsx`	删除了创建 Context 对象的注释。
`src/packages/countdown/countdown.taro.tsx`	删除了与 `locale` 相关的 import 语句。
`src/packages/countdown/countdown.tsx`	删除了与 `locale` 相关的 import 语句。
`src/packages/elevator/elevator.taro.tsx`	删除了重置滚动参数的注释。
`src/packages/elevator/elevator.tsx`	删除了重置滚动参数的注释。
`src/packages/ellipsis/ellipsis.taro.tsx`	删除了与文本展开和折叠处理相关的注释。
`src/packages/ellipsis/ellipsis.tsx`	删除了与文本展开和折叠处理相关的注释。
`src/packages/empty/empty.taro.tsx`	删除了与 `locale` 相关的 import 语句。
`src/packages/empty/empty.tsx`	删除了与 `locale` 相关的 import 语句。
`src/packages/griditem/griditem.taro.tsx`	删除了与 `locale` 相关的 import 语句。
`src/packages/griditem/griditem.tsx`	删除了与 `locale` 相关的 import 语句。
`src/packages/image/image.taro.tsx`	删除了与图像加载和错误处理相关的注释。
`src/packages/image/image.tsx`	删除了与图像加载和错误处理相关的注释。
`src/packages/notify/notify.taro.tsx`	删除了与 `duration` 属性相关的注释。
`src/packages/notify/notify.tsx`	删除了与 `duration` 属性相关的注释。
`src/packages/pagination/pagination.taro.tsx`	删除了与 `handleSelectPage` 函数相关的注释。
`src/packages/pagination/pagination.tsx`	删除了与 `handleSelectPage` 函数相关的注释。
`src/packages/picker/picker.tsx`	删除了与 `confirm` 函数相关的注释。
`src/packages/searchbar/searchbar.taro.tsx`	删除了多个属性，简化了 `SearchBarProps` 接口。
`src/packages/searchbar/searchbar.tsx`	删除了多个属性，简化了 `SearchBarProps` 接口。
`src/packages/signature/signature.taro.tsx`	修改了保存操作失败时的警告信息。
`src/packages/timeselect/timeselect.taro.tsx`	删除了与 `handleSelectTime` 函数相关的注释。
`src/packages/timeselect/timeselect.tsx`	删除了与 `handleSelectTime` 函数相关的注释。
`src/packages/uploader/file-item.ts`	修改了 `FileItem` 类中的 `message` 属性的默认值。
`src/packages/uploader/uploader.taro.tsx`	更新了文件上传按钮的文本以支持本地化。
`src/packages/uploader/uploader.tsx`	更新了文件上传按钮的文本以支持本地化。
`src/sites/assets/styles/variables.scss`	修正了注释中的拼写错误。
`src/sites/doc/components/header/header.scss`	删除了与颜色定义相关的注释。

Possibly related PRs

fix(uploader): 京东小程序中可上传时可选择图片和视频 #2410: uploader 组件的更改与本地化改进和动态按钮标签相关，增强了文件上传的用户界面。
fix(avatarcropper): 修复taro下avatarCropper对象为空的错误 #2364: avatarCropper 组件的错误修复与本次 PR 中引入的本地化属性相关。
fix: 移除不必要的 fragment 元素 #2587: 删除不必要的片段元素与本次 PR 改进代码清晰度的目标一致。

Suggested labels

size/M

兔子在草地上跳跃，
本地化功能真美妙，
新增字符串和翻译，
用户体验更流畅，
代码清晰如春风，
让我们一起欢庆吧！ 🐰✨

Tip

OpenAI O1 model for chat

We have deployed OpenAI's latest O1 model for chat.
OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model.
Please share any feedback with us in the discussions post.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

oasis-cloud · 2024-09-13T10:34:29Z

src/packages/countdown/countdown.taro.tsx

@@ -72,7 +70,7 @@ const InternalCountDown: ForwardRefRenderFunction<
    isPaused: paused,
    isIninted: false,
    timer: 0,
-    restTime: 0, // 倒计时剩余时间时间
+    restTime: 0,


什么时候删注释，什么时候保留注释？

语义化很强的就删掉了~~~

oasis-cloud · 2024-09-13T10:36:58Z

src/packages/signature/signature.taro.tsx

@@ -119,7 +119,7 @@ const InternalSignature: ForwardRefRenderFunction<
            onConfirm && onConfirm(res.tempFilePath, isSignedRef.current)
          },
          fail: (res) => {
-            console.warn('保存失败')
+            console.warn('保存失败', res)


这里没文案吗

这个 warn 中~

warn 中是什么？等待提供翻译文案？

日志数据，不处理多语言

oasis-cloud · 2024-09-13T10:46:19Z

单元测试未通过，需要修改一下

codecov · 2024-09-13T14:14:46Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.95%. Comparing base (7f72a1b) to head (dda26fa).
Report is 3 commits behind head on next.

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #2597      +/-   ##
==========================================
- Coverage   83.11%   82.95%   -0.16%     
==========================================
  Files         218      219       +1     
  Lines       17817    17908      +91     
  Branches     2545     2547       +2     
==========================================
+ Hits        14809    14856      +47     
- Misses       3003     3047      +44     
  Partials        5        5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fix: lint

0a85cc3

pull-request-size bot added the size/L label Sep 13, 2024

xiaoyatong changed the title ~~fix: lint~~ fix: i18n Sep 13, 2024

oasis-cloud requested changes Sep 13, 2024

View reviewed changes

fix: test

147bc3f

fix: test import

dda26fa

oasis-cloud merged commit 28fec26 into jdf2e:next Sep 20, 2024
4 of 5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: i18n #2597

fix: i18n #2597

xiaoyatong commented Sep 13, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 13, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

oasis-cloud Sep 13, 2024

xiaoyatong Sep 13, 2024

oasis-cloud Sep 13, 2024

xiaoyatong Sep 13, 2024

oasis-cloud Sep 13, 2024

xiaoyatong Sep 13, 2024

oasis-cloud commented Sep 13, 2024

codecov bot commented Sep 13, 2024 •

edited

Loading

fix: i18n #2597

fix: i18n #2597

Conversation

xiaoyatong commented Sep 13, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Sep 13, 2024 • edited Loading

Walkthrough

Changes

Possibly related PRs

Suggested labels

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

oasis-cloud Sep 13, 2024

Choose a reason for hiding this comment

xiaoyatong Sep 13, 2024

Choose a reason for hiding this comment

oasis-cloud Sep 13, 2024

Choose a reason for hiding this comment

xiaoyatong Sep 13, 2024

Choose a reason for hiding this comment

oasis-cloud Sep 13, 2024

Choose a reason for hiding this comment

xiaoyatong Sep 13, 2024

Choose a reason for hiding this comment

oasis-cloud commented Sep 13, 2024

codecov bot commented Sep 13, 2024 • edited Loading

Codecov Report

xiaoyatong commented Sep 13, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 13, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Sep 13, 2024 •

edited

Loading