fix(props): add mergeProps utility to resolve all defaultProps warnings #2581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Walkthrough此次变更涉及多个组件的属性合并逻辑，主要通过引入新的实用函数 Changes
Suggested labels
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Alex-huxiyang
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Comment on lines
+18
to
+32
| /** | ||
| * Merge props and return the first non-undefined value. | ||
| * The later has higher priority. e.g. (10, 1, 5) => 5 wins. | ||
| * This is useful with legacy props that have been deprecated. | ||
| */ | ||
| export function mergeProp<T, DefaultT extends T = T>( | ||
| defaultProp: DefaultT, | ||
| ...propList: T[] | ||
| ): T | undefined { | ||
| for (let i = propList.length - 1; i >= 0; i -= 1) { | ||
| if (propList[i] !== undefined) { | ||
| return propList[i] | ||
| } | ||
| } | ||
| return defaultProp |
There was a problem hiding this comment.
批准更改并建议记录使用案例
mergeProp 函数的实现正确地处理了属性列表，并返回第一个非 undefined 值，后面的属性具有更高的优先级。这对于处理已弃用的属性非常有用。建议在文档中添加此函数的使用案例，以帮助开发者了解其在实际场景中的应用。
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #2581 +/- ##
==========================================
- Coverage 83.18% 83.11% -0.07%
==========================================
Files 217 218 +1
Lines 17804 17826 +22
Branches 2543 2546 +3
==========================================
+ Hits 14810 14816 +6
- Misses 2989 3005 +16
Partials 5 5 ☔ View full report in Codecov by Sentry. |
20 tasks
This was referenced Oct 28, 2024
Closed
20 tasks
This was referenced Nov 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
新功能
mergeProps工具函数，以改进多个组件（如ActionSheet、CountUp、BaseDialog、Notify和Toast）中属性的合并逻辑，提升了属性管理的灵活性和可维护性。修复
defaultProps赋值，简化了组件的默认属性管理。文档
mergeProps函数的实现，支持合并多个对象，增强了功能。