feat(Toast): 鸿蒙 适配 #2299
Merged
feat(Toast): 鸿蒙 适配 #2299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 29, 2024 20:50
|
鸿蒙和rn的换行截断demo未适配成功，函数调用demo需要修改一下demo样式，rn弹出样式居中偏下， |
added 2 commits
June 7, 2024 16:45
1）鸿蒙和rn的换行不支持，已屏蔽； |
|
RN 下的展示换行了 |
|
鸿蒙下太宽了 |
oasis-cloud
requested changes
Jun 13, 2024
src/packages/toast/demo.taro.tsx
Outdated
| <Demo5 /> | ||
| </div> | ||
| {/* rn和 鸿蒙不支持 break-all */} | ||
| {Taro.getEnv() === Taro.ENV_TYPE.HARMONYHYBRID || |
There was a problem hiding this comment.
需要合并下 dev- harmony 的代码，环境判断使用 harmonyAndRn() .
Walkthrough此次更改主要集中在 Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ToastComponent
User->>ToastComponent: 请求显示 Toast 通知
activate ToastComponent
ToastComponent-->>User: 显示通知
deactivate ToastComponent
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
src/packages/toast/toast.harmony.css (1)
94-105: 建议增加图标的无障碍支持当前图标实现缺少无障碍支持：
- 需要为图标添加
role="img"属性- 建议添加
aria-label属性以支持屏幕阅读器.nut-toast-icon { width: 24px; height: 24px; color: #ffffff; + role: img; + aria-label: "提示图标"; }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (3)
src/packages/toast/toast.harmony.css(2 hunks)src/packages/toast/toast.scss(5 hunks)src/packages/toast/toast.taro.tsx(8 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- src/packages/toast/toast.scss
- src/packages/toast/toast.taro.tsx
🔇 Additional comments (2)
src/packages/toast/toast.harmony.css (2)
68-73: 请说明 RN 和其他平台位置差异的原因
React Native 平台上的垂直位置（38%）与其他平台（48%）存在显著差异：
- 这种差异可能会导致不一致的用户体验
- 需要明确说明这种差异的必要性
建议：
- 添加注释说明差异的原因
- 考虑是否可以统一处理
10-24: 需要验证 flex-direction 的更改是否影响布局
将 flex-direction 从 column 改为 row 可能会影响内容的垂直堆叠布局。建议：
- 验证此更改对所有平台上的内容布局是否有影响
- 确保图标和文本的垂直排列不受影响
Comment on lines
+27
to
34
| .nut-toast-overlay-default-taro { | ||
| /* #ifdef harmony */ | ||
| background-color: rgba(0, 0, 0, 0); | ||
| z-index: 1300; | ||
| /* #endif */ | ||
| /* #ifndef harmony */ | ||
| /* #endif */ | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
建议重新考虑鸿蒙平台的背景透明度设置
当前实现在鸿蒙平台上将背景色设置为完全透明（rgba(0, 0, 0, 0)），这可能会：
- 降低 Toast 内容的可见性
- 影响用户体验，特别是在复杂背景上
建议添加适当的背景透明度，如 rgba(0, 0, 0, 0.1)。
20 tasks
This was referenced Nov 9, 2024
Merged
Merged
Merged
Merged
This was referenced Nov 20, 2024
Merged
Merged
Merged
Merged
This was referenced Dec 17, 2024
Merged
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个变动的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
☑️ 请求合并前的自查清单
Summary by CodeRabbit
新功能
Toast组件的版本，从2.0.0升级到3.0.0，可能带来了功能上的增强或修改。样式
.nut-toast组件的样式，增强了响应性和适应性，支持不同平台。测试
Toast组件的测试用例，以反映新的类名和样式变化。