fix: 修改Button在服务端不渲染class和style #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oasis-cloud
reviewed
Jun 13, 2022
src/packages/popover/Trigger.tsx
Outdated
| @@ -91,7 +91,7 @@ export default class Trigger extends React.Component<TriggerProps, TriggerState> | |||
| ...newChildProps, | |||
| } | |||
| cloneProps.ref = composeRef(this.props.forwardedRef, (child as any).ref) | |||
| const trigger = React.cloneElement(child, cloneProps) | |||
| const trigger = React.cloneElement(child, cloneProps) as JSX.Element | |||
There was a problem hiding this comment.
已经把Trigger.tsx修改的部分还原了，只更改了Button组件。
还原trigger.tsx，保证每个组件一个PR
getOnce
commented
Jun 13, 2022
src/packages/popover/Trigger.tsx
Outdated
| @@ -91,7 +91,7 @@ export default class Trigger extends React.Component<TriggerProps, TriggerState> | |||
| ...newChildProps, | |||
| } | |||
| cloneProps.ref = composeRef(this.props.forwardedRef, (child as any).ref) | |||
| const trigger = React.cloneElement(child, cloneProps) | |||
| const trigger = React.cloneElement(child, cloneProps) as JSX.Element | |||
There was a problem hiding this comment.
已经把Trigger.tsx修改的部分还原了，只更改了Button组件。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1、修改了按钮服务端渲染的时候不渲染class和style的问题
2、调整了class生成的字符串换行的问题
3、修改Trigger TS校验错误
by liujianchuan