refactor: form #1118
Merged
refactor: form #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/packages/picker/picker.taro.tsx # src/packages/picker/picker.tsx
Codecov Report
@@ Coverage Diff @@
## next #1118 +/- ##
==========================================
+ Coverage 70.27% 70.74% +0.46%
==========================================
Files 187 194 +7
Lines 7579 7796 +217
Branches 2184 2231 +47
==========================================
+ Hits 5326 5515 +189
- Misses 2043 2069 +26
- Partials 210 212 +2
|
xiaoyatong
reviewed
Jun 13, 2023
xiaoyatong
reviewed
Jun 13, 2023
| @@ -442,14 +442,14 @@ | |||
| "author": "dsj" | |||
| }, | |||
| { | |||
| "version": "1.0.0", | |||
| "version": "2.0.0", | |||
| "name": "Form", | |||
src/packages/form/doc.en-US.md
Outdated
| ::: | ||
|
|
||
| ### Top Align | ||
| ### form validation |
src/packages/form/doc.en-US.md
Outdated
| ### Props | ||
|
|
||
| | Property | Description | Type | Default | | ||
| |----------------|--------------|-----------|---| |
src/packages/form/doc.md
Outdated
| | form | 经 Form.useForm() 创建的 form 控制实例，不提供时会自动创建 | `FormInstance` | `-` | | ||
| | footer | 表单底部区域，一般放置确认和重置按钮 | `ReactNode` | `null` | | ||
| | initialValues | 表单初始值 | `any` | `-` | | ||
| | name | 表单名称 | `any` | `\` | |
| | max | 必须设置 type：string 类型为字符串最大长度；number 类型时为最大值；array 类型时为数组最大长度 | `number` | | ||
| | min | 必须设置 type：string 类型为字符串最小长度；number 类型时为最小值；array 类型时为数组最小长度 | `number` | | ||
| | pattern | 正则表达式匹配 | `number` | | ||
| | pattern | 正则表达式匹配 | `RegExp` | |
src/packages/form/doc.md
Outdated
| | 属性 | 说明 | 类型 | | ||
| |----------------| --- | --- | | ||
| | getFieldValue | 获取对应字段名的值 | (name: NamePath) => any | | ||
| | setFieldsValue | 设置表单的值 | (values) => void | |
There was a problem hiding this comment.
get 和 set 是不是要成对，可都支持单个和多个。
src/packages/form/doc.md
Outdated
|
|
||
| | 属性 | 说明 | 类型 | | ||
| |----------------| --- | --- | | ||
| | getFieldValue | 获取对应字段名的值 | (name: NamePath) => any | |
src/packages/form/useform.taro.ts
Outdated
| @@ -46,94 +68,85 @@ class FormStore { | |||
| ...this.store, | |||
| ...newStore, | |||
| } | |||
|
|
|||
| console.log('setFieldsValue', this.store) | |||
src/packages/form/useform.taro.ts
Outdated
|
|
||
| this.fieldEntities.forEach((enetity: FieldEntity) => { | ||
| enetity.onStoreChange() | ||
| console.log('resetFields', this.store, this.initialValues) |
src/packages/form/useform.ts
Outdated
| submit: this.submit, | ||
| store: this.store, | ||
| errList: this.errList, | ||
| errList: this.errors, |
|
uploader 组件的 filelist 变化后，需要有相应的 change 触发。目前 uploader 组件内部没有触发 change |
This was
linked to
issues
Jun 14, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个变动的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
☑️ 请求合并前的自查清单