refactor: TimeSelect #1088
Merged
refactor: TimeSelect #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oasis-cloud
reviewed
Jun 5, 2023
src/packages/timeselect/doc.en-US.md
Outdated
| | Property | Description | Type | Default | | ||
| | --- | --- | --- | --- | | ||
| | visible | whether to display popup | `boolean` | `false` | | ||
| | title | title | `ReactNode` | `取件时间` | |
src/packages/timeselect/doc.en-US.md
Outdated
| const options = [ | ||
| { | ||
| value: 'zhejiang', | ||
| text: '浙江', |
oasis-cloud
reviewed
Jun 5, 2023
| multiple: false, | ||
| currentKey: 0, | ||
| currentTime: [], | ||
| defaultValue: [], | ||
| title: '取件时间', |
| position="bottom" | ||
| style={{ | ||
| width: '100%', | ||
| height: '20%', |
There was a problem hiding this comment.
需要排查高度设置为什么表现出来的和 1.x 不一致
There was a problem hiding this comment.
组件内默认高度一直是 20%。
1.x 的 demo 中设置的高度是 50%，有点太高了，改成 30% 了
oasis-cloud
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.