refactor: signature #1080
Merged
refactor: signature #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oasis-cloud
reviewed
Jun 5, 2023
src/packages/signature/demo.scss
Outdated
| @@ -1,3 +1,13 @@ | |||
| .demo-tips { | |||
| color: #1a1a1a; | |||
| .demo { | |||
There was a problem hiding this comment.
可以给 signarure 一个单独的 className，.demo 的样式有可能影响其他组件的展示
src/packages/signature/demo.taro.tsx
Outdated
|
|
||
| const signatureRef = useRef<signatureRefState>(null) | ||
| const signatureRef1 = useRef<signatureRefState>(null) | ||
|
|
||
| const confirm = (dataurl: string) => { | ||
| console.log('图片地址', dataurl) | ||
| // Taro.saveImageToPhotosAlbum({ |
| @@ -94,18 +94,19 @@ export default App; | |||
|
|
|||
There was a problem hiding this comment.
API 需要改为组件名称 Signature
src/packages/signature/doc.en-US.md
Outdated
|
|
||
| | Property | Description | Type | | ||
| | --- | --- | --- | | ||
| | confirm | 确认签字 | `() => void` | |
| @@ -1,16 +1,4 @@ | |||
| @import '../button/button'; | |||
There was a problem hiding this comment.
button 在组件中没有用到的话，可以不 import button 的样式文件。在 demo 中用到的 button 组件，也不需要在这里 import button 的样式文件
| import Button from '@/packages/button/index.taro' | ||
| import bem from '@/utils/bem' | ||
| import { useConfig } from '@/packages/configprovider/configprovider.taro' | ||
| import { BasicComponent, ComponentDefaults } from '@/utils/typings' | ||
|
|
||
| interface FileType { |
src/packages/signature/signature.tsx
Outdated
| export interface SignatureProps { | ||
| type: string | ||
| export interface SignatureProps extends BasicComponent { | ||
| type: 'png' | 'jpg' |
There was a problem hiding this comment.
可以像 taro 文件中，声明一个同名的类型，在 index 中导出
src/packages/signature/signature.tsx
Outdated
| className: string | ||
| confirm?: (canvas: HTMLCanvasElement, dataurl: string) => void | ||
| clear?: () => void | ||
| unsupported: string |
There was a problem hiding this comment.
这里的类型是不是能改成 ReactNode，如果改为 ReactNode ，下面代码中用到的 unsupported 的地方需要做类型判断，来兼容默认值
oasis-cloud
reviewed
Jun 5, 2023
src/packages/signature/signature.tsx
Outdated
| <p className={`${b('unsopport')}`}> | ||
| {locale.signature.unSupportTpl || unSupportTpl} | ||
| <p className={`${classPrefix}__unsopport}`}> | ||
| {locale.signature.unsupported || unsupported} |
There was a problem hiding this comment.
这个逻辑写反了，使用语言包， 默认值那块可以设置为空
Codecov Report
@@ Coverage Diff @@
## next #1080 +/- ##
=======================================
Coverage ? 69.58%
=======================================
Files ? 187
Lines ? 7589
Branches ? 2189
=======================================
Hits ? 5281
Misses ? 2089
Partials ? 219 |
oasis-cloud
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个变动的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
☑️ 请求合并前的自查清单