Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: card #1069

Merged
merged 3 commits into from
Jun 5, 2023
Merged

refactor: card #1069

merged 3 commits into from
Jun 5, 2023

Conversation

irisSong
Copy link
Collaborator

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fock仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

| --nutui-card-font-size-3 | `$font-size-3` |
| --nutui-card-left-border-radius | `0` |
| --nutui-card-left-background-color | `inherit` |
| Name | Description | Default | | --- | --- | | --nutui-card-font-size-0 | The font size of the card label | `$font-size-0` | | --nutui-card-left-border-radius | The size of the rounded corners of the card picture | `0` | | --nutui-card-left-background-color |卡片图片的背景颜色 | `inherit` |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没翻译,格式看上去不对,现在是一行内容

Copy link
Collaborator

@xiaoyatong xiaoyatong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

当时这个没有评审,所以需要考虑一下 作为业务组件,如何靠齐之前组件定义的props的规范

<div className={b('right__shop')}>
<div className={b('right__shop__name')}>{shopName}</div>
<div className={`${classPrefix}__right__shop`}>
<div className={`${classPrefix}__right__shop__name`}>{shopName}</div>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

考虑中划线

imgUrl: string
title: string
price: string
vipPrice: string
shopDesc: string
delivery: string
shopName: string
className: string
style: React.CSSProperties
prolistTpl: React.ReactNode
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改名。

@oasis-cloud oasis-cloud merged commit 81aa44b into jdf2e:next Jun 5, 2023
@irisSong irisSong deleted the next-card branch January 15, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants