-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: card #1069
refactor: card #1069
Conversation
src/packages/card/doc.en-US.md
Outdated
| --nutui-card-font-size-3 | `$font-size-3` | | ||
| --nutui-card-left-border-radius | `0` | | ||
| --nutui-card-left-background-color | `inherit` | | ||
| Name | Description | Default | | --- | --- | | --nutui-card-font-size-0 | The font size of the card label | `$font-size-0` | | --nutui-card-left-border-radius | The size of the rounded corners of the card picture | `0` | | --nutui-card-left-background-color |卡片图片的背景颜色 | `inherit` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
没翻译,格式看上去不对,现在是一行内容
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
当时这个没有评审,所以需要考虑一下 作为业务组件,如何靠齐之前组件定义的props的规范
src/packages/card/card.taro.tsx
Outdated
<div className={b('right__shop')}> | ||
<div className={b('right__shop__name')}>{shopName}</div> | ||
<div className={`${classPrefix}__right__shop`}> | ||
<div className={`${classPrefix}__right__shop__name`}>{shopName}</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
考虑中划线
src/packages/card/card.taro.tsx
Outdated
imgUrl: string | ||
title: string | ||
price: string | ||
vipPrice: string | ||
shopDesc: string | ||
delivery: string | ||
shopName: string | ||
className: string | ||
style: React.CSSProperties | ||
prolistTpl: React.ReactNode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
改名。
🤔 这个变动的性质是?
🔗 相关 Issue
💡 需求背景和解决方案
☑️ 请求合并前的自查清单