feat: datePicker组件开发 #102
Merged
feat: datePicker组件开发 #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| setShow(visible) | ||
| }, [visible]) | ||
|
|
||
| useEffect(() => {}, [defaultValue]) |
There was a problem hiding this comment.
这行代码好像没什么用
| isVisible={show} | ||
| listData={listData} | ||
| onClose={() => { | ||
| onCloseDatePicker() |
There was a problem hiding this comment.
若无参数，可以直接写为 onClose = { onCloseDatePicker }
src/packages/datepicker/doc.md
Outdated
| const App = () => { | ||
| const minDate = new Date(2020, 0, 1) | ||
| const maxDate = new Date(2025, 10, 1) | ||
| const [show3, setShow4] = useState(false) |
There was a problem hiding this comment.
变量命名，show4 吧
src/packages/datepicker/doc.md
Outdated
| ### 安装 | ||
|
|
||
| ```javascript | ||
| import { DatePicker } from '@nutui/nutui';å |
src/packages/datepicker/doc.md
Outdated
| ### 日期选择-每列不显示中文 | ||
| :::demo | ||
| ```tsx | ||
| import React, { useState, useRef } from "react"; |
There was a problem hiding this comment.
useRef 没有被调用，下面几个例子也是
src/packages/datepicker/doc.md
Outdated
| @@ -0,0 +1,185 @@ | |||
| # Datepicker 日期选择器 | |||
oasis-cloud
requested changes
Mar 7, 2022
| @@ -0,0 +1,345 @@ | |||
| import React, { FunctionComponent, useState, useEffect, useRef } from 'react' | |||
| import './datepicker.scss' | |||
| minDate: Date | ||
| maxDate: Date | ||
| className: '' | ||
| style: {} |
There was a problem hiding this comment.
style 类型应为 React.CSSProperties
| minuteStep: number | ||
| minDate: Date | ||
| maxDate: Date | ||
| className: '' |
There was a problem hiding this comment.
className 类型为 string 类型
| } | ||
|
|
||
| function getMonthEndDay(year: number, month: number): number { | ||
| return 32 - new Date(year, month - 1, 32).getDate() |
| }, | ||
| ] | ||
|
|
||
| switch (type) { |
There was a problem hiding this comment.
switch 建议改成 控制 start 和 end 的，最后处理 slice
| const day = Math.min(formatDate[2], getMonthEndDay(formatDate[0], formatDate[1])) | ||
| let val: (string | number)[] = formatDate | ||
| if (isShowChinese) { | ||
| val = [ |
There was a problem hiding this comment.
可以把索引的解构出来 const [x,x] = formatDate
|
|
||
| const getDateIndex = (type: string, date?: Date) => { | ||
| const curDate = date || currentDate | ||
| if (type === 'year') { |
There was a problem hiding this comment.
这里建议用 switch，看上去会比 if 清晰
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.