fix: lint of menuitem

jdf2e · Oct 10, 2024 · 693adb6 · 693adb6
1 parent bb1d254
commit 693adb6
Showing 1 changed file with 16 additions and 12 deletions.
diff --git a/src/packages/menuitem/menuitem.taro.tsx b/src/packages/menuitem/menuitem.taro.tsx
@@ -90,9 +90,21 @@ export const MenuItem = forwardRef((props: Partial<MenuItemProps>, ref) => {
   useEffect(() => {
     setShowPopup(show)
   }, [show])
+
+  const getParentOffset = useCallback(() => {
+    setTimeout(async () => {
+      const p = parent.menuRef.current
+      const rect = await getRectByTaro(p)
+      setPosition({
+        height: rect.height,
+        top: rect.top,
+      })
+    }, 100)
+  }, [parent.menuRef])
+
   useEffect(() => {
     getParentOffset()
-  }, [showPopup])
+  }, [showPopup, getParentOffset])
 
   const windowHeight = useMemo(() => getSystemInfoSync().windowHeight, [])
   const updateItemOffset = useCallback(() => {
@@ -106,7 +118,8 @@ export const MenuItem = forwardRef((props: Partial<MenuItemProps>, ref) => {
         })
       }
     })
-  }, [direction, windowHeight])
+  }, [direction, windowHeight, parent.lockScroll, parent.menuRef])
+
   usePageScroll(updateItemOffset)
 
   useImperativeHandle<any, any>(ref, () => ({
@@ -136,16 +149,7 @@ export const MenuItem = forwardRef((props: Partial<MenuItemProps>, ref) => {
     top: 0,
     height: 0,
   })
-  const getParentOffset = () => {
-    setTimeout(async () => {
-      const p = parent.menuRef.current
-      const rect = await getRectByTaro(p)
-      setPosition({
-        height: rect.height,
-        top: rect.top,
-      })
-    }, 100)
-  }
+
   const isShow = () => {
     if (showPopup) return {}
     return { display: 'none' }