Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hbonds fixup #1

Merged
merged 3 commits into from
May 8, 2016
Merged

Hbonds fixup #1

merged 3 commits into from
May 8, 2016

Conversation

richardjgowers
Copy link

Fixed the failing test and tidied up a few things in the module

jdetle and others added 3 commits May 6, 2016 21:05
@jdetle
Added real trajectory test
58687ec
@richardjgowers
Fixed up test
3892406
@richardjgowers
Tidied hbond_analysis slightly
64596fc 
Changed distance metrics to staticmethods

Reworked selections to use implicit OR syntax

Used direct bool comparison of Groups
@jdetle
Copy link
Owner

jdetle commented May 7, 2016

Thanks Richard!
On Sat, May 7, 2016 at 4:37 AM Richard Gowers notifications@github.com
wrote:

Fixed the failing test and tidied up a few things in the module

You can view, comment on, or merge this pull request online at:

#1
Commit Summary

  • Fixed up test
  • Tidied hbond_analysis slightly

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#1

Have a wonderful day,
John J. Detlefs

@jdetle jdetle merged commit 439901f into jdetle:hbonds May 8, 2016
@jdetle
Copy link
Owner

jdetle commented May 8, 2016

Sorry, thought I merged this earlier. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richardjgowers @jdetle