Skip to content

Commit

Permalink
Undeprecate otj
Browse files Browse the repository at this point in the history
The otj project released a version that supports JPMS so we can
undeprecate our otj support.

Undoes #2487
  • Loading branch information
hgschmie committed Oct 1, 2023
1 parent 999367a commit 914daab
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -143,14 +143,7 @@ public static JdbiExtension externalPostgres(@Nonnull String hostname,
* should only be used to migrate existing code that uses the JUnit 4 {@link org.jdbi.v3.testing.JdbiRule} quickly to JUnit 5.
*
* @return A {@link JdbiExtension} connected to a managed postgres data source.
* @see JdbiOtjPostgresExtension
* @deprecated The <a href="https://github.com/opentable/otj-pg-embedded/">OtjPostgres project</a> ships its artifact as an automatic module with filename
* based module name. It is strongly discouraged to ship any JPMS enabled project that depends on automatic modules with filename based module names. We
* have reached out to the OtjPostgres project and <a href="https://github.com/opentable/otj-pg-embedded/pull/184">proposed a change that would fix this</a>.
* If they ship a version that fixes this before we are ready to move to full JPMS support, we will un-deprecate this class, otherwise it will be removed
* with our switch to JPMS.
*/
@Deprecated(since = "3.41.2", forRemoval = true) // intellij users need to change the "Usage of API marked for removal" inspection from error to warning
public static JdbiOtjPostgresExtension otjEmbeddedPostgres() {
return JdbiOtjPostgresExtension.instance();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,7 @@
* }
* }</pre>
*
* @deprecated The <a href="https://github.com/opentable/otj-pg-embedded/">OtjPostgres project</a> ships its artifact as an automatic module with filename
* based module name. It is strongly discouraged to ship any JPMS enabled project that depends on automatic modules with filename based module names. We
* have reached out to the OtjPostgres project and <a href="https://github.com/opentable/otj-pg-embedded/pull/184">proposed a change that would fix this</a>.
* If they ship a version that fixes this before we are ready to move to full JPMS support, we will un-deprecate this class, otherwise it will be removed
* with our switch to JPMS.
*/
@Deprecated(since = "3.41.2", forRemoval = true) // intellij users need to change the "Usage of API marked for removal" inspection from error to warning
public class JdbiOtjPostgresExtension extends JdbiExtension {

private volatile EmbeddedPostgres epg;
Expand Down

0 comments on commit 914daab

Please sign in to comment.