Add ServiceAccount creation options

Fixes #3559 Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
jdalrymple · Mar 19, 2024 · 7fdc7b9 · 7fdc7b9
1 parent 1431e84
commit 7fdc7b9
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/.husky/pre-commit b/.husky/pre-commit
@@ -1 +1 @@
-npx --no-install lint-staged
+yarn test
diff --git a/packages/core/src/resources/GroupServiceAccounts.ts b/packages/core/src/resources/GroupServiceAccounts.ts
@@ -3,6 +3,11 @@ import type { AccessTokenSchema } from '../templates/ResourceAccessTokens';
 import { RequestHelper, endpoint } from '../infrastructure';
 import type { GitlabAPIResponse, MappedOmit, ShowExpanded, Sudo } from '../infrastructure';
 
+export interface GroupServiceAccountCreateOptions {
+  name?: string;
+  username?: string;
+}
+
 export interface GroupServiceAccountSchema extends Record<string, unknown> {
   id: number;
   username: string;
@@ -14,7 +19,7 @@ export type ServiceAccountAccessTokenSchema = MappedOmit<AccessTokenSchema, 'acc
 export class GroupServiceAccounts<C extends boolean = false> extends BaseResource<C> {
   create<E extends boolean = false>(
     groupId: string | number,
-    options?: Sudo & ShowExpanded<E>,
+    options?: GroupServiceAccountCreateOptions & Sudo & ShowExpanded<E>,
   ): Promise<GitlabAPIResponse<GroupServiceAccountSchema, C, E, void>> {
     return RequestHelper.post<GroupServiceAccountSchema>()(
       this,

diff --git a/packages/core/src/resources/ServiceAccounts.ts b/packages/core/src/resources/ServiceAccounts.ts
@@ -2,6 +2,11 @@ import { BaseResource } from '@gitbeaker/requester-utils';
 import { RequestHelper, endpoint } from '../infrastructure';
 import type { GitlabAPIResponse, ShowExpanded, Sudo } from '../infrastructure';
 
+export interface ServiceAccountCreateOptions {
+  name?: string;
+  username?: string;
+}
+
 export interface ServiceAccountSchema extends Record<string, unknown> {
   id: number;
   name: string;
@@ -14,7 +19,7 @@ export interface ServiceAccountSchema extends Record<string, unknown> {
 
 export class ServiceAccounts<C extends boolean = false> extends BaseResource<C> {
   create<E extends boolean = false>(
-    options?: Sudo & ShowExpanded<E>,
+    options?: ServiceAccountCreateOptions & Sudo & ShowExpanded<E>,
   ): Promise<GitlabAPIResponse<ServiceAccountSchema, C, E, void>> {
     return RequestHelper.post<ServiceAccountSchema>()(this, endpoint`service_accounts`, options);
   }