Fix JSONDecodeError with 204 responses

jcwillox · Apr 20, 2022 · afc6ec6 · afc6ec6
1 parent 1022850
commit afc6ec6
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/upbankapi/client/_async.py b/upbankapi/client/_async.py
@@ -61,6 +61,8 @@ async def api(
             headers=self._headers,
             url=f"{BASE_URL}{endpoint}",
         ) as response:
+            if response.status == 204:
+                return True
             return self._handle_response(await response.json(), response.status)
 
     async def ping(self) -> str:

diff --git a/upbankapi/client/_sync.py b/upbankapi/client/_sync.py
@@ -50,6 +50,8 @@ def api(
             headers=self._headers,
             url=f"{BASE_URL}{endpoint}",
         )
+        if response.status_code == 204:
+            return True
         return self._handle_response(response.json(), response.status_code)
 
     def ping(self) -> str:

diff --git a/upbankapi/client/base.py b/upbankapi/client/base.py
@@ -45,6 +45,7 @@ def api(
 
     @staticmethod
     def _handle_response(data: Dict, status: int) -> Union[bool, Dict]:
+        # this should have been checked by any calling methods already
         if status == 204:
             return True