Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace **NOTE** with :::info in docs #421

Merged
merged 2 commits into from
Dec 27, 2024
Merged

Replace **NOTE** with :::info in docs #421

merged 2 commits into from
Dec 27, 2024

Conversation

spudoodle
Copy link
Contributor

Reference Issues / PRs

closes #420

What does this implement/fix?

Replaces all the instance of **NOTE** with :::info in the docs

Any other comments?

No

jcubic
jcubic requested changes Dec 27, 2024
View reviewed changes
Copy link
Owner

@jcubic jcubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make all :::info sentences start from uppercase and make sure that if in original text Note is part of the sentence, to add it to note? Like in a case **Note** that.

docs/docs/intro.md Outdated Show resolved Hide resolved
docs/docs/lips/environments.md Show resolved Hide resolved
docs/docs/lips/intro.md Outdated Show resolved Hide resolved
docs/docs/lips/intro.md Outdated Show resolved Hide resolved
docs/docs/lips/intro.md Outdated Show resolved Hide resolved
@spudoodle
Copy link
Contributor Author

Can you make all :::info sentences start from uppercase and make sure that if in original text Note is part of the sentence, to add it to note? Like in a case **Note** that.

I've done the necessary changes

@spudoodle spudoodle requested a review from jcubic December 27, 2024 14:34
jcubic
jcubic approved these changes Dec 27, 2024
View reviewed changes
Copy link
Owner

@jcubic jcubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@jcubic jcubic merged commit c602896 into jcubic:master Dec 27, 2024
4 checks passed
@spudoodle spudoodle deleted the docs/replace-NOTE branch December 27, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcubic jcubic jcubic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace all **NOTE** in documentation
2 participants
@spudoodle @jcubic