Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation errors in 1.19 #412

Closed
sherlock1982 opened this issue Jul 23, 2018 · 2 comments
Closed

Compilation errors in 1.19 #412

sherlock1982 opened this issue Jul 23, 2018 · 2 comments

Comments

@sherlock1982
Copy link

sherlock1982 commented Jul 23, 2018

Expected behavior

To be properly compiled

Actual behavior

× 「atl」: Checking finished with 3 errors × 「wdm」: 1023 modules

ERROR in [at-loader] ./node_modules/jquery.terminal/js/jquery.terminal.d.ts:316:11
TS2430: Interface 'Cmd' incorrectly extends interface 'JQuery'.
Types of property 'resize' are incompatible.
Type '{ (handler: (eventObject: JQueryEventObject) => any): JQuery; (eventData: Object, ha...' is not assignable to type '{ (eventData: TData, handler: EventHandler<HTMLElement, TData> | EventHandlerBase<any, Eve...'.
Type 'JQuery' is not assignable to type 'this'.

ERROR in [at-loader] ./node_modules/jquery.terminal/js/jquery.terminal.d.ts:422:11
TS2430: Interface 'JQueryTerminal' incorrectly extends interface 'JQuery'.
Types of property 'next' are incompatible.
Type '() => JQueryTerminal' is not assignable to type '{ (): this; (selector?: string): this; }'.
Type 'JQueryTerminal' is not assignable to type 'this'.

ERROR in [at-loader] ./src/js/app/console/console.component.ts:36:51
TS2306: File 'C:/root15/Sources/Projects/ManagementConsole/node_modules/jquery.terminal/js/jquery.terminal.d.ts' is not a module.
i 「wdm」: Failed to compile.

jcubic added a commit that referenced this issue Jul 23, 2018
@jcubic
Copy link
Owner

jcubic commented Jul 23, 2018

fixed definition file, the issue was that I was testing on wrog type file for jQuery.

@jcubic
Copy link
Owner

jcubic commented Jul 23, 2018

The fix is in version 1.19.1.

@jcubic jcubic closed this as completed Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants