Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal don't refresh on keypress when scrollbar appear/dissappear #378

Closed
jcubic opened this issue Mar 18, 2018 · 2 comments
Closed

Terminal don't refresh on keypress when scrollbar appear/dissappear #378

jcubic opened this issue Mar 18, 2018 · 2 comments

Comments

@jcubic
Copy link
Owner

jcubic commented Mar 18, 2018

Expected behavior

when you typing and scrollbar appear terminal should adjust the number of characters

Actual behavior

wrapping is wrong

Steps to reproduce

create terminal with some output so it only have one line left for input and type more then one line of text
jcubic added a commit that referenced this issue Mar 18, 2018
@jcubic
fix resize of terminal when scrollbar appear/disappear while you type #…
5aaf96c 
…378
jcubic added a commit that referenced this issue Mar 18, 2018
@jcubic
comment in code for #378
4e741b6
jcubic added a commit that referenced this issue Mar 18, 2018
@jcubic
fix resizing issue when scrollbar appear/disappear while you type #378
76f62c3
@jcubic
Copy link
Owner Author

jcubic commented Mar 18, 2018

Fixed by using iframe as resizer when resizeObserver is not available

@jcubic
Copy link
Owner Author

jcubic commented Mar 24, 2018

in version 1.14.0

@jcubic jcubic closed this as completed Mar 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcubic